Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] migrate product_multi_company #124

Merged
merged 12 commits into from
Mar 9, 2020
Merged

[12.0] migrate product_multi_company #124

merged 12 commits into from
Mar 9, 2020

Conversation

florian-dacosta
Copy link
Contributor

Depends on #123

@OCA-git-bot OCA-git-bot mentioned this pull request May 13, 2019
Closed
9 tasks
@pedrobaeza pedrobaeza added this to the 12.0 milestone May 13, 2019
@florian-dacosta
Copy link
Contributor Author

This PR is now ready.
@pedrobaeza Is it possible to remove the work in progress label?

@LoisRForgeFlow
Copy link
Contributor

@florian-dacosta can you rebase to include that recent merge and see if CI goes green?

@florian-dacosta
Copy link
Contributor Author

Depends on #154 to make the tests green

@florian-dacosta florian-dacosta mentioned this pull request Dec 10, 2019
Closed
pedrobaeza and others added 11 commits December 11, 2019 12:39
@pedrobaeza @florian-dacosta
product_multi_company
37e320d 
==========================================
Product permissions for discrete companies
==========================================

This modules allows to select in which of the companies you want to use each
of the products.

Installation
============

This module uses the post and uninstall hooks for updating default product
template security rule. This only means that updating the module will not
restore the security rule this module changes. Only a complete removal and
reinstallation will serve.

Usage
=====

On the product form view, go to the "Information" tab, and put the companies
in which you want to use that product. If none is selected, the product will
be visible in all of them. The default value is the current one.
@pedrobaeza @florian-dacosta
product_multi_company: Migration to 9.0
fc0e77c
@oca-transbot @florian-dacosta
OCA Transbot updated translations from Transifex
ba89a73
@lasley @florian-dacosta
[MIG] product_multi_company: Upgrade to v10
3e2c153 
* Rename manifest
* Change openerp references to odoo
* Bump version
* Add pragma no cover
* Edit security of product employee to allow writes (in tests)
* Fix permissions in tests
* Fix domain & add test
* Implement base_multi_company on product_multi_company
* Add related cols for product variant
@oca-transbot @florian-dacosta
OCA Transbot updated translations from Transifex
4eed69d
@pedrobaeza @florian-dacosta
[MIG] *_multi_company: OpenUpgrade migration scripts
6c410a1
@oca-transbot @florian-dacosta
OCA Transbot updated translations from Transifex
6ac6208
@cubells @florian-dacosta
[MIG] product_multi_company: Migration to 11.0
afdf477
@oca-travis @florian-dacosta
[UPD] Update product_multi_company.pot
d2aca8e
@pedrobaeza @florian-dacosta
[MIG] product_multi_company: Remove migration scripts
8471053
@florian-dacosta
Migrate product_multi_company to version 12
46eb24a
@florian-dacosta
Copy link
Contributor Author

Test are now green!
@LoisRForgeFlow Do you mind make a review?
@bealdav

@elvise
Copy link

elvise commented Jan 20, 2020

hi, any good news for merge?
how can i help for this task...?

@florian-dacosta
Copy link
Contributor Author

Hello @elvise
A pull request needs at least 2 positive review to be merged.
This one for now has only 1.
If you can test it, review it, and if you think all is ok approve it, it will help.

@pedrobaeza @lmignon @legalsylvain
You were involved in the first PR of this module, would you mind to review this trivial migration?

legalsylvain
legalsylvain reviewed Jan 20, 2020
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A remark. LGTM otherwise.

product_multi_company/readme/DESCRIPTION.rst Outdated
@@ -0,0 +1,3 @@
This module sets the default company taxes for all the existing companies when
a product is created. It also adds a button to set all the taxes from other
companies matching them by tax code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description doesnt seem to be the right one. Don't you think ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it is very strange, I don't understand where this came from...
I fixed this anyway.

bealdav
bealdav approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review migration only, trivial
Thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

Ready to merge?

@bealdav
Copy link
Member

bealdav commented Mar 2, 2020

yes

@florian-dacosta
Copy link
Contributor Author

@LoisRForgeFlow
It is indeed!

@LoisRForgeFlow
Copy link
Contributor

Seems there are no active maintainers for this repo: https://github.com/orgs/OCA/teams/intercompany-maintainers/members.

@pedrobaeza @JordiBForgeFlow could any of you help merging here?

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-124-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9914542 into OCA:12.0 Mar 9, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9a22183. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow
Copy link
Contributor

Thanks Pedro!

@bealdav bealdav deleted the 12.0-mig-product_multi_company branch March 9, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain left review comments

@lmignon lmignon lmignon approved these changes

@bealdav bealdav bealdav approved these changes

@JoanSForgeFlow JoanSForgeFlow JoanSForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.