Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][MIG] account_type_multi_company #73

Merged
merged 3 commits into from
Dec 14, 2017

Conversation

luc-demeyer
Copy link

No description provided.

Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some details. Other than that LGTM

@@ -1,20 +1,23 @@
.. image:: https://img.shields.io/badge/license-AGPL--3-blue.svg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use png image following new standards

and make them multi company aware.

It also adds an active flag on account types.
This module makes the account types multi company aware.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi-company

Obsolete account types defined by e.g. installing multiple
localisation modules can be hidden via the 'account_type_inactive' module.

Both modules can downloaded from git, cf. https://github.com/OCA/account-financial-tools/tree/10.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be

@luc-demeyer
Copy link
Author

@elicoidal
Thanks for the review.
I have fixed the typos.
Changing the svg to png doesn't seem a good idea since
https://img.shields.io/badge/license-AGPL--3-blue.png
does not exist.

@elicoidal
Copy link

@luc-demeyer are you sure? on my side there is an output.
screenshot from 2017-11-14 09-05-32

and wget works fine.

Is there something I am missing

FYI: we removed the svg because it is not rendered properly in the Odoo apps platform

@luc-demeyer
Copy link
Author

@elicoidal
strange but now the png renders fine effectively.
I have updated the PR.

@lasley lasley merged commit 1ca4ce7 into OCA:10.0 Dec 14, 2017
@lasley
Copy link
Contributor

lasley commented Dec 14, 2017

Thanks @luc-demeyer

@lasley lasley added this to the 10.0 milestone Dec 14, 2017
@pedrobaeza pedrobaeza mentioned this pull request Dec 14, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants