[FIX][10.0][multi_company_abstract] Fix company_id computation issue (+ add unit test) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acsonefho
force-pushed
the
fix_multi_company_issue
branch
from
42a00e8
to
82da91d
Compare
|
This seems similar to #86, isn't it? |
acsonefho
force-pushed
the
fix_multi_company_issue
branch
from
82da91d
to
e212e7e
Compare
|
@pedrobaeza Ah yes exactly same issue (so quite similar fix). Sorry, I didn't see it before |
|
No problem. Let's keep this one as better documented and with tests. |
pedrobaeza
requested changes
Mar 27, 2018
base_multi_company/__manifest__.py
Outdated
| @@ -1,12 +1,13 @@ | |||
| # -*- coding: utf-8 -*- | |||
base_multi_company/__manifest__.py
Outdated
| # Copyright 2017 LasLabs Inc. | ||
| # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html). | ||
|
|
||
| { | ||
| 'name': 'Multi Company Base', | ||
| 'summary': 'Provides a base for adding multi-company support to models.', | ||
| 'version': '10.0.1.0.1', | ||
| 'author': "LasLabs, Tecnativa, Odoo Community Association (OCA)", | ||
| 'author': "LasLabs, Tecnativa," | ||
| "ACSONE SA/NV," |
There was a problem hiding this comment.
This patch is not enough for granting you co-authorship. Put you in contributors in README instead.
There was a problem hiding this comment.
Ok no problem. My internal check becomes red due to the coding utf-8 and because I didn't add my company into the module. I'll correct this in few minutes
acsonefho
force-pushed
the
fix_multi_company_issue
branch
3 times, most recently
from
867cc4b
to
e06a3e3
Compare
|
@pedrobaeza The test is red due to another module. Seems ok for you now? |
|
No, @acsonefho , Travis is failing due to this flake8 error in your changes: |
[FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Bad branch version pushed before [FIX] Bad branch version pushed before [FIX] manifest Fix flake Flake8 on OCA tests
acsonefho
force-pushed
the
fix_multi_company_issue
branch
from
e06a3e3
to
8c3f843
Compare
SimoRubi
approved these changes
Apr 20, 2018
pedrobaeza
approved these changes
Apr 23, 2018
This was referenced Apr 23, 2018
SilvioC2C
pushed a commit
to camptocamp/multi-company
that referenced
this pull request
Mar 7, 2023
BSSBG-2615: Complete mrp.production labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce (actual) error:
product.templateinheritmulti.company.abstractcompany_idscompany_idscompany_idof the productcompany_idof the product is the same than the current company, stay on the same product but switch your current company (top right button)company_idof the product is not your actual company: you will have some issue (for example to use pricelist (price list set towithout_discountasdiscount_policy) onsale.orderbecause this model use theproduct.company_id.currency_id=> BOOM,AccessErrorexception because you don't have rights to read another company than the current one).Fix (this MR):
company_idfield of amulti.company.abstract, give the priority to the company of the current user. If this company is not intocompany_idsof the targeted model, pick the first company (actual behaviour)