Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] attribute_set: assure _instanciate_attrs doesn't break #135

Merged
merged 1 commit into from
May 11, 2023
Merged

[14.0][FIX] attribute_set: assure _instanciate_attrs doesn't break #135

merged 1 commit into from
May 11, 2023

Conversation

MiquelRForgeFlow
Copy link
Contributor

Fixes #134.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 14.0-fix-attribute_set-_instanciate_attrs branch from 65872d0 to 7b71cfd Compare January 11, 2023 12:28
HviorForgeFlow
HviorForgeFlow approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

@MiquelRForgeFlow
Copy link
Contributor Author

@simahawk @sebastienbeau pls review and merge :)

simahawk
simahawk requested changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, any chance to have a test?

attribute_set/models/ir_model_fields.py Outdated Show resolved Hide resolved
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 14.0-fix-attribute_set-_instanciate_attrs branch 2 times, most recently from 676cc96 to e2d6c3e Compare January 30, 2023 09:49
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 14.0-fix-attribute_set-_instanciate_attrs branch from e2d6c3e to 7cd1d10 Compare January 30, 2023 09:51
@flotho flotho mentioned this pull request Mar 23, 2023
Closed
@MiquelRForgeFlow
Copy link
Contributor Author

Also, any chance to have a test?

I don't have time nor interest in doing that, but I can say that it have been tested and works fine.

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-135-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 88196dc into OCA:14.0 May 11, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 95c8cd2. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 14.0-fix-attribute_set-_instanciate_attrs branch May 11, 2023 08:36
@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[14.0] attribute_set: Failed to load serialized attribute field
4 participants
@MiquelRForgeFlow @simahawk @OCA-git-bot @HviorForgeFlow