Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] Migrate attribute_set_completeness + product_attribute_set_completeness #55

Merged
merged 32 commits into from
Jun 9, 2021
Merged

[13.0] Migrate attribute_set_completeness + product_attribute_set_completeness #55

merged 32 commits into from
Jun 9, 2021

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Oct 8, 2020

No description provided.

@simahawk simahawk mentioned this pull request Oct 8, 2020
Closed
8 tasks
@simahawk simahawk marked this pull request as ready for review October 8, 2020 16:08
@simahawk simahawk force-pushed the 13-a_set_completeness branch 2 times, most recently from e03d30b to ab41b7f Compare October 8, 2020 16:17
@simahawk
Copy link
Contributor Author

simahawk commented Oct 8, 2020

@lmignon any idea why linting should fail here?
pre-commit/linting config seems equal on 12.0 and 13.0, I don't get why it is complaining. I've tried disabling that check but no luck.

simahawk
simahawk commented Oct 9, 2020
View reviewed changes
attribute_set/views/attribute_attribute_view.xml
@@ -66,10 +66,14 @@
'readonly': [('model_id', '=', False)],
}"
/>
<!--
TODO @CPigeon: why no create?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cedric-Pigeon ping ;)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, I do not remember.

@simahawk simahawk mentioned this pull request Oct 9, 2020
Closed
@simahawk
Copy link
Contributor Author

@lmignon any idea why linting should fail here?
pre-commit/linting config seems equal on 12.0 and 13.0, I don't get why it is complaining. I've tried disabling that check but no luck.

@simahawk simahawk closed this Mar 15, 2021
@simahawk simahawk reopened this Mar 15, 2021
@simahawk simahawk force-pushed the 13-a_set_completeness branch 2 times, most recently from 5937122 to 2bb81df Compare March 15, 2021 16:35
@simahawk
Copy link
Contributor Author

@sbidoul tests are failing because ERROR: No matching distribution found for odoo13-addon-attribute_set_completeness -> but I'm migrating the module here. Of course, I can add a temporary dependency but maybe we should install local modules automatically otherwise it's impossible to migrate 2 modules where one depends on the other in the same PR.
I can split this PR if there's no workaround.

@sbidoul
Copy link
Member

sbidoul commented Mar 15, 2021

Oh, right, my last optimization attempt is broken. Just a moment please.

@sbidoul
Copy link
Member

sbidoul commented Mar 15, 2021

@simahawk it's better now.

@simahawk
Copy link
Contributor Author

@Cedric-Pigeon fine for you? :)

Cedric-Pigeon
Cedric-Pigeon approved these changes Mar 16, 2021
View reviewed changes
Copy link

@Cedric-Pigeon Cedric-Pigeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@simahawk
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

@simahawk The merge process could not start, because of exception 403 Must have push access to view repository collaborators..

@sbidoul
Copy link
Member

sbidoul commented Mar 16, 2021

@simahawk @sebastienbeau @Cedric-Pigeon What was decided for this repo in terms of PSC ? A new PSC or joining the Product PSC with new members ? @simahawk can you take care of configuration ?

@simahawk
Copy link
Contributor Author

I see that only "Product maintainers" is assigned here. So, PSC: ok. As for other permissions, I'll add them.

@simahawk
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-55-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 16, 2021
@OCA-git-bot
Merge PR #55 into 13.0
52ec2bc 
Signed-off-by simahawk
simahawk and others added 21 commits June 9, 2021 07:42
@simahawk
attribute_set_completeness: tests use SavepointComponentCase
4e5e11e
@simahawk
attribute_set_completeness 12.0.1.2.0
a363803
@simahawk
[MIG] attribute_set_completeness: Migration to 13.0
7a0ca26
@simahawk
attribute_set: allow create group from set
db80ac2
@simahawk
attribute_set: set view add default model for group
cdf2fa5
@simahawk
attr_set_completeness: set view add default model for completeness rec
f23bfcc
@simahawk
[ADD] add new features to manage completion rate and completion state…
adf6fca 
… on models linked to attribute set
@simahawk
[UPD] README.rst
e47fd53
@simahawk
product_attribute_set_completeness 12.0.1.0.1
8fd80f0
@rousseldenis @simahawk
[10.0][FIX] attribute_set_completeness: Add not completed fields
7aee25c
@rousseldenis @simahawk
[10.0][IMP] pre-commit updates
e1f2dd0
@simahawk
product_attribute_set_completeness: fix completion_rate widget
bc3a5a4
@simahawk
product_attribute_set_completeness 12.0.1.1.0
1d81cbf
@simahawk
[FIX] attribute_set_completeness: speed up completion fields
ee3a384
@simahawk
product_attribute_set_completeness 12.0.1.2.0
314b202
@simahawk
[MIG] product_attribute_set_completeness: Migration to 13.0
0c05657
@simahawk
att_set_completeness: fix duplicated label
a5ee3e5
@simahawk
att_set_completeness: fix _compute_completion rate no config
fd94b49 
When no config is found, the attribute_set_not_completed_ids must be computed anyway.
@simahawk
att_set_completeness: fix linting
d230490
@simahawk
pim: fwd port attribute_set_completeness integration
793fbdc
@simahawk
Make pre-commit happy
b1337ca
@simahawk
Copy link
Contributor Author

simahawk commented Jun 9, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-55-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c3bf088 into OCA:13.0 Jun 9, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8e41092. Thanks a lot for contributing to OCA. ❤️

@simahawk simahawk mentioned this pull request Jun 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cedric-Pigeon Cedric-Pigeon Cedric-Pigeon approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simahawk @sbidoul @OCA-git-bot @Cedric-Pigeon @pedrobaeza @rousseldenis