[FIX] _convert_field_bootstrap_4to5_sql: Detect json and convert its values #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Thanks @hbrunn ! (just fix pre-commit format suggestions) 👍
hbrunn
force-pushed
the
master-_convert_field_bootstrap_4to5_sql-json
branch
from
6bde193
to
2981518
Compare
|
thanks for the heads-up! |
chienandalu
approved these changes
Dec 26, 2023
pedrobaeza
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to the docs, we can rely on those values to be dicts.
Fixes OCA/OpenUpgrade#4263