-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] operating_unit: Migration to 17.0 #667
Conversation
…per the OCA guidelines.
* [MIG] operating_unit to v10.0
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the migration and the refactor. Functional tests are good so far. Tested it using the migration of the account_operating_unit module for it. When the uneeded file is removed then I am fine with a merge.
6773332
to
eff2a7d
Compare
eff2a7d
to
3befa88
Compare
@AaronHForgeFlow @gurneyalex |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
This PR has the |
Congratulations, your PR was merged at 549a3b0. Thanks a lot for contributing to OCA. ❤️ |
Just a quick message to thanks everyone for the help and the reviews on these modules. FYI I will probably work on operating units during OCA days. For now, I have two improvements :
|
Compare to 16.0, I added a new method in the model "res.users". The method is inspired by the one on companies (https://github.com/odoo/odoo/blob/7266a662171fedc945523c5bc1bb34a4dd0995bf/odoo/api.py#L645) in the idea that at some point maybe a selector widget (like company one) will be added to choose the active OUs