[10.0][MIG][IMP] mis_builder_operating_unit #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aheficent I'll resolve the conflict as soon as #87 is merged. |
sbidoul
force-pushed
the
10.0-mis_builder_operating_unit-sbi
branch
from
d2cf0da
to
a53bff4
Compare
|
rebased |
|
I added an operating filter on |
|
That is really cool! |
|
I restored and accidentally deleted view. |
sbidoul
commented
Mar 19, 2018
| self.report_instance_id.operating_unit_ids.ids)) | ||
| if self.operating_unit_ids: | ||
| aml_domain.append(('operating_unit_id', 'in', | ||
| self.operating_unit_ids.ids)) |
There was a problem hiding this comment.
I think we need some sudo here otherwise running reports that filter on operating units with users that don't have access to said operating units give funny results.
There was a problem hiding this comment.
Do you mean to override the _search method in the account_move_line? https://github.com/OCA/operating-unit/blob/10.0/account_operating_unit/models/account_move.py#L11
This allows displaying operating units side by sides.
(see comment in code)
sbidoul
force-pushed
the
10.0-mis_builder_operating_unit-sbi
branch
from
1d9c2c5
to
f752c92
Compare
sbidoul
changed the title
|
I rebased again. Can we consider merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forward port of #38 plus one fix for the record rule
cc/ @jbeficent