[10.0] [ADD] hr_expense_operating_unit #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aheficent Could you please review. |
|
@nikul-serpentcs Will you include here the commit history of https://github.com/OCA/operating-unit/pull/30/commits ? |
|
sure @aheficent |
| self.hr_expense2 = self._create_hr_expense( | ||
| self.b2c, self.emp) | ||
|
|
||
| self._post_journal_entries(self.hr_expense1) |
There was a problem hiding this comment.
This is ok. However, I miss a test that check the operating units for the journal items created.
|
Thank you @nikul-serpentcs I'll approve this when the commit history is fixed |
|
@aheficent but still open branch here #30 |
nikul-serpentcs
force-pushed
the
10.0-hr_expense_operating_unit
branch
from
3dba960
to
af691d0
Compare
|
@aheficent I somehow managed to preserve the commits 😄 becoming GIT Guru 🙏 |
AaronHForgeFlow
approved these changes
Jul 21, 2017
AaronHForgeFlow
force-pushed
the
10.0-hr_expense_operating_unit
branch
from
af691d0
to
c82945f
Compare
serpentcs-dev1
approved these changes
Jun 27, 2018
|
Don't panic, travis stopped but it is not red :) I restarted the job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HR Expense with Operating Units
This module introduces the following features:
Adds the Operating Unit (OU) to the Expense.
Security rules are defined to ensure that users can only see the Expense of that Operating Units in which they are allowed access to.
Adds Operating Unit (OU) to the account moves while generating accounting entries from the expense.