Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] partner_multi_relation: Translation string couldn't be parsed correctly using str.format KeyError('kategori') issue #1783

Closed
wants to merge 1 commit into from

Conversation

yankinmax
Copy link
Contributor

This fix is needed to stop having pre-commit failing on other PR's.

…orrectly using str.format KeyError('kategori') issue
@gurneyalex
Copy link
Member

gurneyalex commented Jun 17, 2024

I'm fine with the change but it has to be implemented through weblate, because the post merge scripts will revert the translations (unless I'm mistaken, maybe @sbidoul can confirm)

I made the change in weblate -> it should sync in a few hours.

@yankinmax
Copy link
Contributor Author

yankinmax commented Jun 17, 2024

@gurneyalex for me more important is to merge approved:

@gurneyalex
Copy link
Member

It can't be merged now the CI will be red, and the oca bot will refuse to merge.

I've just changed the translation in the weblate UI, it should get merged in the next run of the cron, at which point the issue will be fix. Let's check this again tomorrow.

@gurneyalex
Copy link
Member

677e517 fixed the issue

@gurneyalex gurneyalex closed this Jun 18, 2024
@sbidoul
Copy link
Member

sbidoul commented Jun 23, 2024

I'm fine with the change but it has to be implemented through weblate, because the post merge scripts will revert the translations (unless I'm mistaken, maybe @sbidoul can confirm)

@gurneyalex weblate will not revert translations but may get into a git merge conflict if there are ongoing translations at the same time, and such merge conflicts are painful to resolve. That is why we strongly discourage pushing translations via git, but it can be done in some circumstances.

@sbidoul
Copy link
Member

sbidoul commented Jun 24, 2024

BTW, we should enable more checks in weblate to avoid these translation errors: OCA/oca-weblate-deployment#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants