9.0 [MIG] partner_contact_department migration #327
Conversation
|
|
||
| .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/134/8.0 |
| Images | ||
| ------ | ||
|
|
||
| * `Antiun Ingeniería S.L. <http://www.antiun.com>`_: Icon. |
There was a problem hiding this comment.
This image credit is not correct. Remove it.
| "summary": "Assign contacts to departments", | ||
| 'version': '9.0.1.0.0', | ||
| 'category': 'Customer Relationship Management', | ||
| 'author': 'Serv. Tecnol. Avanzados - Pedro M. Baeza, ' |
There was a problem hiding this comment.
Remove both old company references and put Tecnativa
| _description = "Department" | ||
|
|
||
| name = fields.Char(required=True, translate=True) | ||
| parent_id = fields.Many2one( |
|
cc @Tecnativa |
|
The squash operation hasn't been correct. |
| "summary": "Assign contacts to departments", | ||
| 'version': '9.0.1.0.0', | ||
| 'category': 'Customer Relationship Management', | ||
| 'author': 'Tecnativa S.L. - Vicent Cubells, ' |
| @@ -11,7 +11,7 @@ | |||
| "summary": "Assign contacts to departments", | |||
| 'version': '9.0.1.0.0', | |||
| 'category': 'Customer Relationship Management', | |||
| 'author': 'Tecnativa S.L. - Vicent Cubells, ' | |||
| 'author': 'Tecnativa - Vicent Cubells, ' | |||
There was a problem hiding this comment.
Sorry, I wasn't see the second part, but it's only Tecnativa at all, also without "Vicent Cubells". Your name is put on the README in the contributors section and also on each file header.
| @@ -11,7 +11,7 @@ | |||
| "summary": "Assign contacts to departments", | |||
| 'version': '9.0.1.0.0', | |||
| 'category': 'Customer Relationship Management', | |||
| 'author': 'Tecnativa S.L. - Vicent Cubells, ' | |||
| 'author': 'Tecnativa - Vicent Cubells, ' | |||
| "Odoo Community Association (OCA)", | |||
| "license": "AGPL-3", | |||
| 'website': 'http://www.antiun.com', | |||
|
Vicent, this one stills contains weird commits. Can you fix it? |
|
Can you do a similar test than job_position? |
|
Yes, I can. |
|
cc @pedrobaeza I can't do an squash of the transbot commits. Even if I do an squash of two consecutive commits I've got an error. Weird. |
There was a problem hiding this comment.
Hi, you have to use git rebase -i origin/9.0 and follow instructions at the bottom of the file git opens to you to fixup those consecutive commits. No conflict should appear.
Also, please keep a sane history. As you might guess, having commits from 6d3c9a1 to 3183145 with the same meaningless message will not be merged until fixed. OTOH code looks alright 😉
| _description = "Department" | ||
|
|
||
| name = fields.Char(required=True, translate=True) | ||
| parent_id = fields.Many2one( |
cubells
force-pushed
the
9.0-mig-partner_contact_department
branch
2 times, most recently
from
2e1bd81
to
d74d6d4
Compare
|
cc @Tecnativa |
|
OK, this looks better 😉 I'll review it |
- Update translation. - Reduce garbage code. - Update license and copyright headers. - Improve README. - Drop CRM stuff.
* Add tests
* Other minor changes
pedrobaeza
force-pushed
the
9.0-mig-partner_contact_department
branch
from
d74d6d4
to
5e09fe0
Compare
No description provided.