[9.0] [MIG] base_partner_sequence module #358
Conversation
cubells
changed the title
rafaelbn
added
work in progress
needs fixing
needs review
and removed
work in progress
needs fixing
labels
| "category": "Generic Modules/Base", | ||
| "website": "http://www.initos.com", | ||
| "depends": ["base"], | ||
| "website": "http://www.tecnativa.com", |
| partner's 'ref' | ||
| """ | ||
| if not vals and not partner_id: | ||
| raise Exception('Either field values or an id must be provided.') |
| <field name="inherit_id" ref="base.view_partner_form"/> | ||
| <field name="arch" type="xml"> | ||
| <field name="ref" position="attributes"> | ||
| <attribute name="attrs">{ |
There was a problem hiding this comment.
Put this in only line for not messing up architecture view in Odoo
|
There's also a strange repetition of commits that you should put together |
| super(ResPartner, partner).write(vals) | ||
| return True | ||
|
|
||
| @api.one |
cubells
force-pushed
the
9.0-mig-base_partner_sequence
branch
from
abddcf3
to
be1a4a1
Compare
cubells
force-pushed
the
9.0-mig-base_partner_sequence
branch
from
be1a4a1
to
3b6827f
Compare
|
|
||
| :param parnter_id: id of the partner object | ||
| :param vals: known field values of the partner object | ||
| :return: true iff a sequence value should be assigned to the\ |
There was a problem hiding this comment.
typo - partner
typo - non blocking
typo - unnecessary trailing slash
| "category": "Generic Modules/Base", | ||
| "website": "http://www.initos.com", | ||
| "depends": ["base"], |
There was a problem hiding this comment.
I know ordinarily there is an implicit dependency on base, but in this case, because the module is directly referencing base xml ids I think it would be better to explicitly state. I've only done a static review and not tested, so don't know whether this would ever actually cause a problem on a fresh database.
There was a problem hiding this comment.
actually, having tested in runbot, it seems that on a fresh install it will pick up base xml ids so ignore this comment if you choose.
pedrobaeza
force-pushed
the
9.0-mig-base_partner_sequence
branch
from
3b6827f
to
3c52174
Compare
pedrobaeza
force-pushed
the
9.0-mig-base_partner_sequence
branch
from
3c52174
to
49e826d
Compare
|
Tanks @pedrobaeza |
cc @Tecnativa