Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][IMP] base_location(geonames): Add Lat/Long #405

Merged
merged 2 commits into from
Apr 24, 2017
Merged

[10.0][IMP] base_location(geonames): Add Lat/Long #405

merged 2 commits into from
Apr 24, 2017

Conversation

lasley
Copy link
Contributor

@lasley lasley commented Apr 15, 2017 •
edited
Loading

This PR contains two modules base_location and base_location_geonames_importer, but they are minor changes in both and entirely related:

[IMP] base_location: Add lat & long to better.zip

  • Add latitude and longitude columns to better.zip

[IMP] base_location_geonames_import: Add lat/long

  • Add support for latitude & longitude to genomes importer

I specifically did not use geoengine so as to not require PostGIS. We can create a glue module pretty easily I think, so we can have the best of both worlds (see OCA/geospatial#136).

I also did not add the lat/long into any views, because I don't really feel they will be useful for humans. Please let me know if you feel otherwise.

@lasley
[IMP] base_location: Add lat & long to better.zip
1621928 
* Add latitude and longitude columns to `better.zip`
@lasley
[IMP] base_location_geonames_import: Add lat/long
70621b0 
* Add support for latitude & longitude to genomes importer
@lasley lasley changed the title Feature/10.0/base location lat long [10.0][IMP] base_location(geonames_importer): Add Lat/Long Apr 15, 2017
@lasley lasley changed the title [10.0][IMP] base_location(geonames_importer): Add Lat/Long [10.0][IMP] base_location(geonames): Add Lat/Long Apr 15, 2017
@lasley
Copy link
Contributor Author

lasley commented Apr 15, 2017

Assuming tests pass, can a PSC please mark as 10.0 milestone & Ready for Review please and thanks!

@lasley lasley mentioned this pull request Apr 15, 2017
Closed
@rvalyi
Copy link
Member

rvalyi commented Apr 15, 2017

👍 seems both useful and very simple

lasley
lasley commented Apr 15, 2017
View reviewed changes
base_location/models/better_zip.py
@@ -20,6 +20,8 @@ class BetterZip(models.Model):
city = fields.Char('City', required=True)
state_id = fields.Many2one('res.country.state', 'State')
country_id = fields.Many2one('res.country', 'Country')
latitude = fields.Float()
longitude = fields.Float()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there is also an accuracy in GeoNames that I don't personally care about but would have no problems implementing if someone does.

accuracy          : accuracy of lat/lng from 1=estimated to 6=centroid

@elicoidal elicoidal added this to the 10.0 milestone Apr 15, 2017
@lasley
Copy link
Contributor Author

lasley commented Apr 23, 2017

Good for merge?

@rafaelbn
Copy link
Member

AS @rvalyi approve it also I merge #405 (comment)

@rafaelbn rafaelbn merged commit ff78566 into OCA:10.0 Apr 24, 2017
@lasley lasley deleted the feature/10.0/base_location_lat_long branch August 11, 2017 00:48
etobella pushed a commit to etobella/partner-contact that referenced this pull request Oct 9, 2017
@lasley @etobella
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
8b3b271 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
etobella pushed a commit to etobella/partner-contact that referenced this pull request Oct 10, 2017
@lasley @etobella
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
89196f6 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
JordiBForgeFlow pushed a commit to ForgeFlow/partner-contact that referenced this pull request Oct 13, 2017
@lasley @JordiBForgeFlow
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
06af6be 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
etobella pushed a commit to etobella/partner-contact that referenced this pull request Nov 2, 2017
@lasley @etobella
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
22c69ac 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
TDu pushed a commit to TDu/partner-contact that referenced this pull request Nov 13, 2017
@lasley @TDu
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
24c46ec 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
etobella pushed a commit to etobella/partner-contact that referenced this pull request Nov 13, 2017
@lasley @etobella
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
ec26d2d 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
yajo pushed a commit that referenced this pull request Nov 15, 2017
@lasley @yajo
[10.0][IMP] base_location(geonames): Add Lat/Long (#405)
576477a 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
JordiBForgeFlow pushed a commit to ForgeFlow/partner-contact that referenced this pull request Nov 17, 2017
@lasley @JordiBForgeFlow
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
8962dfb 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
JordiBForgeFlow pushed a commit to ForgeFlow/partner-contact that referenced this pull request Nov 17, 2017
@lasley @JordiBForgeFlow
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
503d0e1 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
JordiBForgeFlow pushed a commit to ForgeFlow/partner-contact that referenced this pull request Nov 17, 2017
@lasley @JordiBForgeFlow
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
4c76858 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
JordiBForgeFlow pushed a commit to ForgeFlow/partner-contact that referenced this pull request Nov 17, 2017
@lasley @JordiBForgeFlow
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
1959058 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
JordiBForgeFlow pushed a commit to ForgeFlow/partner-contact that referenced this pull request Nov 20, 2017
@lasley @JordiBForgeFlow
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
b8c5e94 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to ForgeFlow/partner-contact that referenced this pull request Nov 21, 2017
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
f8fa487 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
aitorbouzas pushed a commit to aitorbouzas/partner-contact that referenced this pull request Oct 8, 2018
@lasley @aitorbouzas
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
e7981cb 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
aitorbouzas pushed a commit to aitorbouzas/partner-contact that referenced this pull request Oct 8, 2018
@lasley @aitorbouzas
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
32d7dd6 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to aitorbouzas/partner-contact that referenced this pull request Jan 30, 2019
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
2f0bcec 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
victormmtorres pushed a commit to Tecnativa/partner-contact that referenced this pull request Mar 25, 2019
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
e4e9344 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
victormmtorres pushed a commit to Tecnativa/partner-contact that referenced this pull request Mar 25, 2019
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
78a63c1 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Sep 30, 2019
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
4b1d23f 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Sep 30, 2019
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
e96e899 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Sep 30, 2019
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
77ee08f 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Oct 4, 2019
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
cde17a0 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Oct 18, 2020
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
676590f 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
alexis-via pushed a commit to akretion/partner-contact that referenced this pull request Nov 26, 2020
@lasley @alexis-via
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
33623b8 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Dec 15, 2020
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
466f203 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit that referenced this pull request Oct 29, 2021
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (#405)
9a74d18 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Nov 16, 2021
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
ba10a62 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
holdenrehg pushed a commit to holdenrehg/partner-contact that referenced this pull request Nov 27, 2021
@lasley @holdenrehg
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
b13419e 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
holdenrehg pushed a commit to holdenrehg/partner-contact that referenced this pull request Nov 27, 2021
@lasley @holdenrehg
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
cdeb627 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Oct 7, 2022
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
1aa8114 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Oct 18, 2022
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
555ec50 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
victor-champonnois pushed a commit to coopiteasy/partner-contact that referenced this pull request Feb 3, 2023
@lasley @victor-champonnois
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
e137f0f 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
victor-champonnois pushed a commit to coopiteasy/partner-contact that referenced this pull request Feb 3, 2023
@lasley @victor-champonnois
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
0472a0c 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
royaurelien pushed a commit to apikcloud/partner-contact that referenced this pull request Jan 24, 2024
@lasley @royaurelien
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
a575448 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
beagle-cloud pushed a commit to DynAppsNV/partner-contact that referenced this pull request Jan 30, 2024
@lasley
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
7e45753 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
beagle-cloud pushed a commit to DynAppsNV/partner-contact that referenced this pull request Feb 26, 2024
@lasley
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
b4080fa 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Feb 29, 2024
@lasley @pedrobaeza
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
a5dc1ac 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
@lasley @edlopen
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
4c2a058 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
@lasley @edlopen
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
ea72af5 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
@lasley @edlopen
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
6830f12 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
@lasley @edlopen
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
8a5b16e 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
Kimkhoi3010 pushed a commit to Kimkhoi3010/partner-contact that referenced this pull request Oct 14, 2024
@lasley @Kimkhoi3010
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
dad8bd4 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
Kimkhoi3010 pushed a commit to Kimkhoi3010/partner-contact that referenced this pull request Oct 15, 2024
@lasley @Kimkhoi3010
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
e26b2ce 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
Kimkhoi3010 pushed a commit to Kimkhoi3010/partner-contact that referenced this pull request Oct 29, 2024
@lasley @Kimkhoi3010
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
423cfdf 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
Kimkhoi3010 pushed a commit to Kimkhoi3010/partner-contact that referenced this pull request Oct 29, 2024
@lasley @Kimkhoi3010
[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)
129c4fb 
* [IMP] base_location: Add lat & long to `better.zip`
* Add latitude and longitude columns to `better.zip`

* [IMP] base_location_geonames_import: Add lat/long
* Add support for latitude & longitude to genomes importer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicoidal elicoidal elicoidal approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lasley @rvalyi @rafaelbn @elicoidal