Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] crm_deduplicate_filter > partner_deduplicate_filter: Migration to 12.0 #726

Merged
merged 7 commits into from
Apr 5, 2019

Conversation

victormmtorres
Copy link

No description provided.

pedrobaeza and others added 2 commits April 4, 2019 12:13
===========================================
Exclude some records from the deduplication
===========================================

This module extends the possibilities of the contact deduplication allowing
to filter the applicable set according several criteria.

For now, only the filter for restricting the deduplication to only companies or
only contacts is implemented.

Usage
=====

To use this module, you need to:

   "Parent company set (Contacts)" in the section 'Exclude contacts having'.
   kind of records.
@victormmtorres victormmtorres changed the title 12.0 partner deduplicate filter [MIG] crm_deduplicate_filter > partner_deduplicate_filter: Migration to 12.0 Apr 4, 2019
@victormmtorres
Copy link
Author

@Tecnativa

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netpicking

partner_deduplicate_filter/README.rst Outdated Show resolved Hide resolved
partner_deduplicate_filter/__manifest__.py Outdated Show resolved Hide resolved
@pedrobaeza pedrobaeza added this to the 12.0 milestone Apr 4, 2019
@victormmtorres victormmtorres force-pushed the 12.0-partner_deduplicate_filter branch 2 times, most recently from b70211e to 7c8f35a Compare April 4, 2019 14:23
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victormmtorres please remember to drop a comment when you do a change and forced push, as we are not notified in that case.

partner_deduplicate_filter/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
@victormmtorres victormmtorres force-pushed the 12.0-partner_deduplicate_filter branch from 7c8f35a to cc58248 Compare April 4, 2019 16:23
@pedrobaeza
Copy link
Member

@nikul-serpentcs you can review again

@OCA-git-bot OCA-git-bot mentioned this pull request Apr 4, 2019
20 tasks
@nikul-serpentcs
Copy link
Member

@nikul-serpentcs you can review again

Yes Sure

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM 👍

@nikul-serpentcs
Copy link
Member

@victormmtorres @pedrobaeza Squash 2 commit is more better

MIG  crm_deduplicate_filter   partner_deduplicate_filter  Migration to 12 0 by victormmtorres · Pull Request  726 · OCA partner contact

@pedrobaeza
Copy link
Member

@nikul-serpentcs that commits are not adjacent, and there are migration commits in between, so that's not possible without conflicts.

@pedrobaeza pedrobaeza merged commit 4ccc474 into OCA:12.0 Apr 5, 2019
@pedrobaeza pedrobaeza deleted the 12.0-partner_deduplicate_filter branch April 5, 2019 07:18
chienandalu pushed a commit to Tecnativa/partner-contact that referenced this pull request Nov 28, 2019
…lter

[MIG] crm_deduplicate_filter > partner_deduplicate_filter: Migration to 12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants