Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] New module for smart tags #825

Merged
merged 4 commits into from
Feb 11, 2021
Merged

[ADD] New module for smart tags #825

merged 4 commits into from
Feb 11, 2021

Conversation

ecino
Copy link

@ecino ecino commented Dec 10, 2019

This module enables to use ir.filters and res.partner.category to automatically assign tags on contacts that match given domain criterias.

@pedrobaeza
Copy link
Member

Name should follow standard patterns, including the main area (partner), and subarea after (tag), so I suggest partner_tag_smart_assignation or similar.

@ecino ecino force-pushed the 11.0-smart-tag branch 2 times, most recently from a7088af to 75a6f11 Compare December 10, 2019 14:21
@ecino
Copy link
Author

ecino commented Dec 10, 2019

Thanks, I updated the headers, and the readme.

nikul-serpentcs
nikul-serpentcs reviewed Dec 11, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved code

partner_tag_smart_assignation/__manifest__.py Outdated Show resolved Hide resolved
partner_tag_smart_assignation/__manifest__.py Outdated Show resolved Hide resolved
@ecino
Copy link
Author

ecino commented Dec 20, 2019

Copyright and url fixed.

@rousseldenis rousseldenis added this to the 11.0 milestone Dec 20, 2019
@rousseldenis
Copy link
Contributor

@ecino Could you fix pylint (manifest error)?

@ecino
Copy link
Author

ecino commented Jan 15, 2020

@rousseldenis Fixed

rousseldenis
rousseldenis requested changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one. Code review. Needs to fix somes.

partner_tag_smart_assignation/models/res_partner_category.py Outdated Show resolved Hide resolved
partner_tag_smart_assignation/models/res_partner_category.py Outdated Show resolved Hide resolved
partner_tag_smart_assignation/models/res_partner_category.py Outdated Show resolved Hide resolved
partner_tag_smart_assignation/models/res_partner_category.py Outdated Show resolved Hide resolved
partner_tag_smart_assignation/models/res_partner_category.py Outdated Show resolved Hide resolved
partner_tag_smart_assignation/models/res_partner_category.py Outdated Show resolved Hide resolved
@ecino
Copy link
Author

ecino commented Jan 29, 2020

@rousseldenis Thanks for the helpful review, I made your suggested changes and added a small feature for using SQL queries in parallel of ir.filters (which is very handy for quick filters setup).

@NL66278
Copy link
Contributor

NL66278 commented Jan 14, 2021

Close and reopen to check wether this will fix runbot error.

@NL66278 NL66278 closed this Jan 14, 2021
@NL66278 NL66278 reopened this Jan 14, 2021
NL66278
NL66278 approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@NL66278
Copy link
Contributor

NL66278 commented Feb 11, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-825-by-NL66278-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c64f08c into OCA:11.0 Feb 11, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dcd3ece. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis requested changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs left review comments

@pedrobaeza pedrobaeza pedrobaeza left review comments

@NL66278 NL66278 NL66278 approved these changes

Assignees
No one assigned
Labels
merged 🎉 needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ecino @pedrobaeza @rousseldenis @NL66278 @OCA-git-bot @nikul-serpentcs