Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] hr_payroll_period: Add a cron to create next fiscal year automatically #162

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

AaronHForgeFlow
Copy link
Contributor

@OCA-git-bot
Copy link
Contributor

Hi @nimarosa,
some modules you are maintaining are being modified, check this out!

@nimarosa
Copy link
Contributor

@AaronHForgeFlow Please consider adding some tests for the funcitonality, so we can be sure it works okay in futher migrations.

@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-imp-hr_payroll_fiscalyear-cron branch 2 times, most recently from aecba5e to d5e610e Compare July 12, 2024 06:12
@AaronHForgeFlow
Copy link
Contributor Author

@nimarosa test added.

I also made the cron archived by default, so it is up to anyone to enable it or not

@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-imp-hr_payroll_fiscalyear-cron branch from d5e610e to 470536a Compare August 27, 2024 15:17
@nimarosa
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@nimarosa The rebase process failed, because command git push --force ForgeFlow tmp-pr-162:15.0-imp-hr_payroll_fiscalyear-cron failed with output:

remote: Permission to ForgeFlow/payroll.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/ForgeFlow/payroll/': The requested URL returned error: 403

@nimarosa nimarosa added this to the 15.0 milestone Sep 26, 2024
@nimarosa
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-162-by-nimarosa-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e65c970 into OCA:15.0 Sep 26, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 55caf63. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants