Porting pos_payment_terminal to 9.0 #105
Conversation
|
|
||
| <template id="assets_backend" name="point_of_sale assets" inherit_id="web.assets_backend"> | ||
| <xpath expr="." position="inside"> | ||
| <script type="text/javascript" src="/pos_payment_terminal/static/src/js/pos_payment_terminal.js"></script> |
There was a problem hiding this comment.
If you remove this, JavaScript is being ignored, isn't it?
There was a problem hiding this comment.
Hi pedro, it is just refactoring. the include is here : https://github.com/OCA/pos/pull/105/files#diff-23a25d4fe2ebc9a4291377ba6c07a1aeR7
|
Hey @yuntux, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
There was a problem hiding this comment.
👍 when my PR will be merged https://github.com/yuntux/pos/pull/1
|
@yuntux, can you please merge the PR to your branch? |
|
Hi, is this PR ready to mege?, what do you need to do it?, may I help?. |
|
@libreec, you can help reviewing the PR. |
|
Hi @yuntux , are you going yo continue this PR migration? if no answer I will close this PR. Maybe @alexis-via would like yo retake it including his PR... We will review it. thanks |
|
Closing, due to inactivity. @alexis-via, please free to make another, based on your PR against this PR. |
This PR port the pos_payment_terminal module to Odoo 9.0.
It's my first OCA PR. I have sent my CLA 5 minutes ago.