Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] pos_lot_barcode: Migration to 17.0 #1105

Merged
merged 13 commits into from
Jan 26, 2024

Conversation

nguyenminhchien
Copy link
Contributor

ref: BSRD-704

@nguyenminhchien nguyenminhchien marked this pull request as ready for review December 6, 2023 02:27
@nguyenminhchien nguyenminhchien mentioned this pull request Dec 6, 2023
30 tasks
@legalsylvain
Copy link
Contributor

/ocabot migration pos_lot_barcode

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 6, 2023
@gurneyalex
Copy link
Member

/ocabot migration pos_lot_barcode

@Fabrizio1305
Copy link

Fabrizio1305 commented Dec 11, 2023

Not working.
Tested flow:

  1. activate lots on products
  2. take a product available in POS, and update qty to create an entry with a LOT (make sure the lot number doesn't exist yet for any product), make sure the product doesn't have qty in stock without a LOT (to avoid inconsistencies)
    (optional: print the lot barcode)
  3. open POS
  4. add that product to a cart the standard way, with the lot number you just created.
  5. Scan the lot barcode (or activate debug panel and enter the lot number manually in the debug panel and push scan)
  6. the same product as point 4 should be added automatically to the cart.
  7. finalize the transaction by paying in cash and closing the POS
  8. and double check that the proper product and lot has been taken out of stock (inventory moves)

In my test, I'm stuck on point 5 as the product/lot is not found on scanning (both in debug mode and with the physical scanner).
tested only together with #1106

@nguyenminhchien
Copy link
Contributor Author

Not working. Tested flow:

1. activate lots on products

2. take a product available in POS, and update qty to create an entry with a LOT (make sure the lot number doesn't exist yet for any product), make sure the product doesn't have qty in stock without a LOT (to avoid inconsistencies)
   (optional: print the lot barcode)

3. open POS

4. add that product to a cart the standard way, with the lot number you just created.

5. Scan the lot barcode (or activate debug panel and enter the lot number manually in the debug panel and push scan)

6. the same product as point 4 should be added automatically to the cart.

7. finalize the transaction by paying in cash and closing the POS

8. and double check that the proper product and lot has been taken out of stock (inventory moves)

In my test, I'm stuck on point 5 as the product/lot is not found on scanning (both in debug mode and with the physical scanner). tested only together with #1106

@Fabrizio1305 hi, what Lot Barcode did you test ? did it march to Barcode pattern of Default Nomenclature you defined in your POS?
fyi, here is the default Barcode pattern added by Odoo
image

@Fabrizio1305
Copy link

Good point, double checked, and lot line was after the product line, moved it above and now it finds the product but doesn't add it to the cart, a manual confirmation is needed, and slowing downs the process. in v16 was adding it directly to the cart.
Also when you scan products with the product's barcode there isn't a confirmation step, and it's normal, as the process should flow without hiccups.

@nguyenminhchien
Copy link
Contributor Author

@Fabrizio1305 the popup is shown when you select the product (track=Lot), or scan its barcode (NOT Lot barcode). If you scan the Lot barcode, related product will be added to cart immediately. Check my screencast below:

Screencast.from.12-12-2023.09.51.36.webm

@gurneyalex
Copy link
Member

/ocabot migration pos_lot_barcode

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1105-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5f08fea into OCA:17.0 Jan 26, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 016e734. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants