[FIX] remove unrelated code to pos_pricelist and fix #128 #236
Conversation
|
Change module version number |
|
Thanks for the review @pedrobaeza. Done. |
| line.set_quantity(options.quantity); | ||
| } | ||
| if (options.price !== undefined) { | ||
| line.set_unit_price(options.price); |
There was a problem hiding this comment.
Maybe this is for setting the correct price and it's needed?
There was a problem hiding this comment.
No it's not. you'll find the same line in the Odoo code.
see original overwritten function :
https://github.com/odoo/odoo/blob/8.0/addons/point_of_sale/static/src/js/models.js#L1066
and
the comment of the function in the OCA module talks about lines merging.
https://github.com/OCA/pos/pull/236/files/c879f74940fbd11ed3f13d75c820fd500980d3c4#diff-747f62729cafe771e948f5cfeb9aff46L81
regards.
| if (self.get('orderLines').models !== undefined) { | ||
| orderlines = self.get('orderLines').models; | ||
| } | ||
| for (var i = 0; i < orderlines.length; i++) { |
There was a problem hiding this comment.
I think it's this hidden feature: upstream Odoo only considers the last line to merge with, this change considers all lines on the order. It should probably go into OCB instead.
There was a problem hiding this comment.
yep, it's not the place. (and overwrite function is allways a good way to generate bugs).
Ideally, it should be an option. In some cases, users want to merge all lines, sometime no lines. (but it's another story).
thanks for the review @StefanRijnhart.
Hi all,
I was trying to investigate on the bug #128, and for the time being, the bug occurs on a fresh database with pos_pricelist installed.
the reason is the change with an overwrite of the function addProduct (without calling super)
Looking more deeply, I just realized that this function has nothing to do with pos_pricelist and allow to merge lines, even if it's not the last line.
this feature can be great, but has nothing to do with this module.
I so removed the full function :
@imaralux : can you test ?
@AdilHoumadi, could you take a look ?
CC : @StefanRijnhart, @pablocm-aserti, @antespi