Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] [MIG] POS Restricted Customer List #343

Merged
merged 9 commits into from
Jun 7, 2019
Merged

[9.0] [MIG] POS Restricted Customer List #343

merged 9 commits into from
Jun 7, 2019

Conversation

ThomasBinsfeld
Copy link

@ThomasBinsfeld ThomasBinsfeld force-pushed the 9.0-mig_pos_restricted_customer_list_tbi branch 4 times, most recently from b595701 to 63b56aa Compare April 25, 2019 10:12
rousseldenis
rousseldenis approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@rousseldenis
Copy link
Contributor

Travis is red for lint errors related to other modules

chienandalu
chienandalu requested changes Apr 26, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't properly test it on runbot, as some other modules in this branch seem to have bad interactions. Here are some comments anyway:

pos_restricted_customer_list/__openerp__.py Show resolved Hide resolved
pos_restricted_customer_list/static/src/js/pos_restricted_customer_list.js Outdated Show resolved Hide resolved
pos_restricted_customer_list/static/src/js/pos_restricted_customer_list.js Show resolved Hide resolved
pos_restricted_customer_list/models/res_partner.py Show resolved Hide resolved
benwillig
benwillig approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@benwillig benwillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there could be a _get_partner_domain method but otherwise LGTM 👍

@ThomasBinsfeld ThomasBinsfeld force-pushed the 9.0-mig_pos_restricted_customer_list_tbi branch 2 times, most recently from 3146ae2 to b968c45 Compare April 26, 2019 12:46
@rousseldenis
Copy link
Contributor

9.0 branch is red as Travis could not launch

@chienandalu
Copy link
Member

@ThomasBinsfeld I fixed 9.0 travis, so you can rebase to get green travis

@ThomasBinsfeld
Copy link
Author

@ThomasBinsfeld I fixed 9.0 travis, so you can rebase to get green travis

@chienandalu Thanks a lot! Rebased.

@ThomasBinsfeld ThomasBinsfeld force-pushed the 9.0-mig_pos_restricted_customer_list_tbi branch from b968c45 to 45b96ff Compare June 3, 2019 07:52
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit ec68665 into OCA:9.0 Jun 7, 2019
@pedrobaeza pedrobaeza added this to the 9.0 milestone Jun 7, 2019
@pedrobaeza pedrobaeza mentioned this pull request Jun 7, 2019
Closed
11 tasks
@ThomasBinsfeld ThomasBinsfeld deleted the 9.0-mig_pos_restricted_customer_list_tbi branch June 21, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@benwillig benwillig benwillig approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
9 participants
@ThomasBinsfeld @rousseldenis @chienandalu @OCA-git-bot @benwillig @pedrobaeza @NL66278 @oca-transbot @oca-travis