-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] pos_lot_selection: Migration to 16.0 #935
Conversation
With PR odoo/odoo#23698 merged, clone control is no longer needed for lots. [FIX] pos_lot_selection: group lots by quants fixup! [FIX] pos_lot_selection: group lots by quants fixup! fixup! [FIX] pos_lot_selection: group lots by quants
Object.assign is introduced in ES6 (2015) which is not supported by PhantomJS. Replace it with the equivalent _.extend function to prevent frontend tests from failing. 1. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Specifications 2. ariya/phantomjs#14506
Currently translated at 100.0% (1 of 1 strings) Translation: pos-11.0/pos-11.0-pos_lot_selection Translate-URL: https://translation.odoo-community.org/projects/pos-11-0/pos-11-0-pos_lot_selection/ca/
Regular Point of Sale Users with the minimal access rights are not allowed to read the `stock.production.lot` model.
eda6b74
to
3cedf8a
Compare
3cedf8a
to
4d7b4e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a technical point of view, but not tested functionnaly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically LG
As the module has no test tours, have you manually tested it ? 🤔
/ocabot migration pos_lot_selection |
4d7b4e3
to
7424d19
Compare
/ocabot merge nobump |
On my way to merge this fine PR! |
@ivantodorovich The merge process could not start, because of exception <class 'requests.exceptions.ReadTimeout'>: A connection-level exception occurred: HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=10). |
Congratulations, your PR was merged at 0fd9007. Thanks a lot for contributing to OCA. ❤️ |
Tested functionally and compared with v15