Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] pos_lot_selection: Migration to 16.0 #935

Merged
merged 18 commits into from
Feb 28, 2023

Conversation

yankinmax
Copy link
Contributor

@yankinmax yankinmax commented Feb 27, 2023

Tested functionally and compared with v15

chienandalu and others added 17 commits February 27, 2023 18:31
With PR odoo/odoo#23698 merged, clone control is
no longer needed for lots.

[FIX] pos_lot_selection: group lots by quants

fixup! [FIX] pos_lot_selection: group lots by quants

fixup! fixup! [FIX] pos_lot_selection: group lots by quants
Object.assign is introduced in ES6 (2015) which is not supported by
PhantomJS. Replace it with the equivalent _.extend function to prevent
frontend tests from failing.

1. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Specifications
2. ariya/phantomjs#14506
Currently translated at 100.0% (1 of 1 strings)

Translation: pos-11.0/pos-11.0-pos_lot_selection
Translate-URL: https://translation.odoo-community.org/projects/pos-11-0/pos-11-0-pos_lot_selection/ca/
Regular Point of Sale Users with the minimal access rights are not
allowed to read the `stock.production.lot` model.
@yankinmax yankinmax force-pushed the 16.0-mig-pos_lot_selection branch 6 times, most recently from eda6b74 to 3cedf8a Compare February 28, 2023 08:32
@yankinmax yankinmax mentioned this pull request Feb 28, 2023
37 tasks
Copy link

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a technical point of view, but not tested functionnaly

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LG

As the module has no test tours, have you manually tested it ? 🤔

@ivantodorovich
Copy link
Contributor

/ocabot migration pos_lot_selection

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 28, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#849) has been updated to reference the current pull request.
however, a previous pull request was referenced : #917.
Perhaps you should check that there is no duplicate work.
CC : @juliette-blanc

@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-935-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@ivantodorovich The merge process could not start, because of exception <class 'requests.exceptions.ReadTimeout'>: A connection-level exception occurred: HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=10).

@OCA-git-bot OCA-git-bot merged commit 963087b into OCA:16.0 Feb 28, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0fd9007. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants