Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][16.0] stock_production_lot_expiry #1214

Closed
wants to merge 4 commits into from
Closed

[MIG][16.0] stock_production_lot_expiry #1214

wants to merge 4 commits into from

Conversation

glitchov
Copy link
Contributor

migration from 10.0

@rousseldenis
Copy link
Contributor

/ocabot migration stock_production_lot_expiry

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 29, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 29, 2022
Open
55 tasks
rousseldenis
rousseldenis approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @glitchov Could you fix string ?

stock_production_lot_expiry/models/product_template.py Outdated
@@ -23,11 +23,12 @@ class ProductTemplate(models.Model):
category_lot_expiry_field_name = fields.Selection(
related="categ_id.lot_expiry_field_name",
readonly=True,
string="category_lot_expiry_field_name",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something more explicit ???

@rousseldenis
Copy link
Contributor

@alexis-via Maybe this one could be your interest

@glitchov glitchov force-pushed the 16.0-mig-stock_production_lot_expiry branch from b20adf8 to 818fcbb Compare November 30, 2022 12:19
@alexis-via
Copy link

Instead of adding a new computed field "is_expiry", you could use the native computed field "product_expiry_alert" (https://github.com/odoo/odoo/blob/16.0/addons/product_expiry/models/production_lot.py#L21) and add a search method on it.

This module adds "yet another" date field on production lot... so it's a total of 5 date fields (4 datetime and 1 date). With some imagination, I think we could reach 10 date fields anytime soon :)
I'm sorry, but I prefer my module "product_expiry_simple", with just 1 date field... so much simpler and easier to understand for users.

rousseldenis
rousseldenis reviewed Dec 1, 2022
View reviewed changes
stock_production_lot_expiry/models/stock_lot.py Outdated

_inherit = "stock.lot"

is_expired = fields.Boolean(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbaudoux @glitchov Maybe we could use the product_expiry_alertcore field as that one is used in some flows, for instance there : https://github.com/odoo/odoo/blob/16.0/addons/product_expiry/models/stock_move_line.py#L16

@glitchov glitchov force-pushed the 16.0-mig-stock_production_lot_expiry branch from 818fcbb to 382d397 Compare December 5, 2022 13:18
sbejaoui
sbejaoui approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review),

should we rename the module to stock_lot_expiry?

@glitchov glitchov force-pushed the 16.0-mig-stock_production_lot_expiry branch from d1d1d4b to 5002d5d Compare January 24, 2023 08:44
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon
Copy link
Contributor

lmignon commented Jan 24, 2023

@OCA/product-maintainers Someone to merge this one?

jbaudoux
jbaudoux reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot is expired on its expiration date. And it is supposed to be removed from stock on its removal date.

It is not clear the intent of this module reading the description. Looks weird.

@rousseldenis
Copy link
Contributor

@lmignon

@lmignon
Copy link
Contributor

lmignon commented Feb 15, 2023

@rousseldenis I propose to close this one... (It makes non sense)

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 18, 2023
@github-actions github-actions bot closed this Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@jbaudoux jbaudoux jbaudoux left review comments

@sbejaoui sbejaoui sbejaoui approved these changes

Assignees
No one assigned
Labels
approved migration needs review ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@glitchov @rousseldenis @alexis-via @OCA-git-bot @lmignon @jbaudoux @sbejaoui