Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] product_search_by_display_name #1299

Merged
merged 1 commit into from
Dec 22, 2023
Merged

[14.0][ADD] product_search_by_display_name #1299

merged 1 commit into from
Dec 22, 2023

Conversation

cuongnmtm
Copy link

No description provided.

@cuongnmtm cuongnmtm force-pushed the 14.0-product_search_by_display_name branch 5 times, most recently from ba326de to a5638f4 Compare March 16, 2023 13:40
hieulucky111
hieulucky111 approved these changes Mar 31, 2023
View reviewed changes
Copy link

@hieulucky111 hieulucky111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
LGTM

CoraVanga
CoraVanga approved these changes Apr 21, 2023
View reviewed changes
Copy link

@CoraVanga CoraVanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Leonidas-VII
Leonidas-VII approved these changes Apr 21, 2023
View reviewed changes
Copy link

@Leonidas-VII Leonidas-VII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@cuongnmtm cuongnmtm force-pushed the 14.0-product_search_by_display_name branch from b0beb04 to 512f6ea Compare June 20, 2023 03:59
@dreispt
Copy link
Member

dreispt commented Nov 6, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1299-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 6, 2023
@OCA-git-bot
Merge PR #1299 into 14.0
4441e40 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1299-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@cuongnmtm cuongnmtm force-pushed the 14.0-product_search_by_display_name branch from 512f6ea to eef55df Compare December 1, 2023 12:52
@dreispt
Copy link
Member

dreispt commented Dec 22, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1299-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e4dbf8a into OCA:14.0 Dec 22, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fa757db. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DucTruongKomit DucTruongKomit DucTruongKomit left review comments

@Leonidas-VII Leonidas-VII Leonidas-VII approved these changes

@hildickethan hildickethan hildickethan approved these changes

@CoraVanga CoraVanga CoraVanga approved these changes

@hieulucky111 hieulucky111 hieulucky111 approved these changes

@klodr klodr klodr approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cuongnmtm @OCA-git-bot @dreispt @klodr @hieulucky111 @DucTruongKomit @CoraVanga @hildickethan @Leonidas-VII