[17.0][MIG] product_net_weight : Migration to 17.0 #1677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new net_weight field on product models; - Rename weight field with 'Gross Weight' string;
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-15.0/product-attribute-15.0-product_net_weight Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_net_weight/
Currently translated at 88.8% (8 of 9 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_net_weight Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_net_weight/es/
…with multiple variants
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_net_weight Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_net_weight/
Currently translated at 100.0% (7 of 7 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_net_weight Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_net_weight/es/
Currently translated at 100.0% (7 of 7 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_net_weight Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_net_weight/it/
|
@peeranutjobgo Do you mind if we switch to this ? /ocabot migration product_net_weight |
drewes
reviewed
Jul 23, 2024
| invisible="product_variant_count > 1 and not is_product_variant" | ||
| > | ||
| <field name="net_weight" class="oe_inline" /> | ||
| <span><field name="weight_uom_name" /></span> |
There was a problem hiding this comment.
Would recommend to remove the elements to align units with the standard product form
There was a problem hiding this comment.
@drewes a new PR where the issue is fixed https://github.com/OCA/product-attribute/pull/1735/files
drewes
reviewed
Jul 23, 2024
| <label for="net_weight" /> | ||
| <div class="o_row"> | ||
| <field name="net_weight" /> | ||
| <span><field name="weight_uom_name" /></span> |
There was a problem hiding this comment.
Would remove to align unit with standard product form (and in additions below)
|
@rousseldenis @pedrobaeza pls merge |
|
What about the last 2 pending comments? |
alexis-via
approved these changes
Sep 30, 2024
bosd
approved these changes
Oct 1, 2024
Borruso
approved these changes
Oct 8, 2024
|
supersedeed by #1740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #1520
The PR #1520 has issues with remaining
attrsin view causing a Raise at module installation