Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_code_mandatory #1697

Merged
merged 36 commits into from
Aug 2, 2024

Conversation

ced-adhoc
Copy link

@ced-adhoc ced-adhoc commented Jul 30, 2024

Based on migration PR to v16: #1693

agyamuta and others added 30 commits July 30, 2024 12:33
* [ADD] Module to set the  internal reference of the product as required.
Currently translated at 100.0% (3 of 3 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_code_mandatory/pt/
Currently translated at 83.3% (5 of 6 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr/
Currently translated at 83.3% (5 of 6 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr_FR/
Currently translated at 100.0% (2 of 2 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/
mymage and others added 5 commits July 30, 2024 12:33
Currently translated at 100.0% (3 of 3 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/it/
Move setUp test class to setUpClass for better performant

[ADD] product_code_mandatory: Add contributors

[IMP] product_cost_security: clarify product cost edit required permissions

As seen in OCA/margin-analysis#198 (review), a user needs some other group that grants them permissions for editing products, apart from this one that allows them to edit product cost.

This might not seem obvious to the user, so it's better to document it.

Btw, I renamed the groups to be shorter. Still easy to understand, now that groups are grouped (🥁).

@moduon MT-5158

[UPD] Update product_cost_security.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_cost_security
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_cost_security/
@ced-adhoc ced-adhoc force-pushed the 17.0-mig-product_code_mandatory branch 2 times, most recently from 9c97ab6 to c5fb225 Compare July 30, 2024 19:06
Copy link

@florenciafrigieri2 florenciafrigieri2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, working ok. It adds an internal reference to products and variants when they're empty.

@jcadhoc
Copy link

jcadhoc commented Jul 31, 2024

@pedrobaeza Hi Pedro!

What do you think about this pr? I think we can merge it.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration product_code_mandatory
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 2, 2024
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1697-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Aug 2, 2024
58 tasks
@OCA-git-bot OCA-git-bot merged commit bcb8bab into OCA:17.0 Aug 2, 2024
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cafbc95. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.