-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] product_code_mandatory #1697
[17.0][MIG] product_code_mandatory #1697
Conversation
* [ADD] Module to set the internal reference of the product as required.
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_code_mandatory/pt/
Currently translated at 83.3% (5 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr/
Currently translated at 83.3% (5 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr_FR/
Currently translated at 100.0% (2 of 2 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/it/
Move setUp test class to setUpClass for better performant [ADD] product_code_mandatory: Add contributors [IMP] product_cost_security: clarify product cost edit required permissions As seen in OCA/margin-analysis#198 (review), a user needs some other group that grants them permissions for editing products, apart from this one that allows them to edit product cost. This might not seem obvious to the user, so it's better to document it. Btw, I renamed the groups to be shorter. Still easy to understand, now that groups are grouped (🥁). @moduon MT-5158 [UPD] Update product_cost_security.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_cost_security Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_cost_security/
9c97ab6
to
c5fb225
Compare
c5fb225
to
29b61df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review, working ok. It adds an internal reference to products and variants when they're empty.
@pedrobaeza Hi Pedro! What do you think about this pr? I think we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot migration product_code_mandatory
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at cafbc95. Thanks a lot for contributing to OCA. ❤️ |
Based on migration PR to v16: #1693