-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][ADD] product_readonly_security: New module #1704
[13.0][ADD] product_readonly_security: New module #1704
Conversation
877c138
to
0b519f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review LGTM Thanks!
This PR has the |
0b519f8
to
8bd00fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
@pedrobaeza The merge process could not be finalized, because command
|
/ocabot merge nobump |
On my way to merge this fine PR! |
@pedrobaeza The merge process could not be finalized, because command
|
@sbidoul do you know what happens with this failing merge? |
Could it be |
@victoralmau did you manually create that file? Can you remove it if not to let the merge bot to regenerate it? |
8bd00fd
to
d2e6801
Compare
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-1704-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Ouch, it seems the files are needed by pre-commit. @victoralmau please run pre-commit locally again and re-push. |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-1704-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
d2e6801
to
a09df11
Compare
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at c8c060c. Thanks a lot for contributing to OCA. ❤️ |
New module
Please @pedrobaeza and @carolinafernandez-tecnativa can you review it?
@Tecnativa TT50471