Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][ADD] product_readonly_security: New module #1704

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Aug 8, 2024

New module

Please @pedrobaeza and @carolinafernandez-tecnativa can you review it?

@Tecnativa TT50471

@victoralmau victoralmau force-pushed the 13.0-add-product_readonly_security branch 3 times, most recently from 877c138 to 0b519f8 Compare August 8, 2024 11:36
@victoralmau victoralmau marked this pull request as ready for review August 8, 2024 11:41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 13.0 milestone Aug 19, 2024
@victoralmau victoralmau force-pushed the 13.0-add-product_readonly_security branch from 0b519f8 to 8bd00fd Compare August 19, 2024 07:23
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-1704-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 19, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command /tmp/tmpwrzcqwqe/bin/python setup.py bdist_wheel --dist-dir /tmp/tmpv1z2pk7m --bdist-dir /tmp/tmpn_m3s7qa --python-tag py3 failed with output:

/tmp/tmpwrzcqwqe/lib/python3.12/site-packages/setuptools/__init__.py:81: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
!!

        ********************************************************************************
        Requirements should be satisfied by a PEP 517 installer.
        If you are using pip, you can try `pip install --use-pep517`.
        ********************************************************************************

!!
  dist.fetch_build_eggs(dist.setup_requires)
error in setup command: /tmp/tmp9_xkip25/setup/product_readonly_security/odoo/addons must contain exactly one installable Odoo addon dir, found []

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-1704-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 19, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command /tmp/tmpwrzcqwqe/bin/python setup.py bdist_wheel --dist-dir /tmp/tmpyzjomik_ --bdist-dir /tmp/tmpf47hnrup --python-tag py3 failed with output:

/tmp/tmpwrzcqwqe/lib/python3.12/site-packages/setuptools/__init__.py:81: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
!!

        ********************************************************************************
        Requirements should be satisfied by a PEP 517 installer.
        If you are using pip, you can try `pip install --use-pep517`.
        ********************************************************************************

!!
  dist.fetch_build_eggs(dist.setup_requires)
error in setup command: /tmp/tmp9acoc7qy/setup/product_readonly_security/odoo/addons must contain exactly one installable Odoo addon dir, found []

@pedrobaeza
Copy link
Member

@sbidoul do you know what happens with this failing merge?

@sbidoul
Copy link
Member

sbidoul commented Aug 19, 2024

Could it be setup/product_readonly_security/odoo/addons/product_readonly_security is a regular file instead of a symlink?

@pedrobaeza
Copy link
Member

@victoralmau did you manually create that file? Can you remove it if not to let the merge bot to regenerate it?

@victoralmau victoralmau force-pushed the 13.0-add-product_readonly_security branch from 8bd00fd to d2e6801 Compare August 19, 2024 15:20
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-1704-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 19, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-1704-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Ouch, it seems the files are needed by pre-commit. @victoralmau please run pre-commit locally again and re-push.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-1704-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@victoralmau victoralmau force-pushed the 13.0-add-product_readonly_security branch from d2e6801 to a09df11 Compare August 19, 2024 16:23
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-1704-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 84f7858 into OCA:13.0 Aug 19, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c8c060c. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 13.0-add-product_readonly_security branch August 19, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants