Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packs "Totalized in main product" and "Non Detailed" don't include product list price #169

Open
bruno-zanotti opened this issue May 6, 2024 · 2 comments
Labels
bug Something isn't working stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@bruno-zanotti
Copy link
Contributor

Module

product_pack - sale_product_pack - website_sale_product_pack

Describe the bug

When you get the price of a pack "Totalized in main product" or "Non Detailed" the result is only the sum of the components and list price of the product pack is ignored. This isn't the behavior in other pack types making the modules more confusing to use or implement.

To Reproduce

Affected versions: 14.0, 15.0, 16.0

Steps to reproduce the behavior:

  1. Go to runboat or install the modules with demo data.
  2. Create a sale order and add the product "Pack CPU (Detailed - Totalized Components Price)"
  3. The price you will get is: $2,662.50
  4. When the expected price should be: $30.75 (list pack price) + $2,662.50 (sum of components) = $2,693.25

For example, if you add the exact same pack but with the setting "Detailed per component" the total price will be $2,693.25

Expected behavior

  1. Doesn't matter the type of the pack if the components and the list price is the same should get the same price.
  2. The "Totalized in main product" and "Non Detailed" should add the list price to the pack total price (even if you don't want it, it can be set in 0)

Screenshot of a sale quotation from runboat
pack_comparison

@bruno-zanotti bruno-zanotti added the bug Something isn't working label May 6, 2024
@bruno-zanotti
Copy link
Contributor Author

After the price refactor #149 is merged, this issue should be solved with #164

bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue May 15, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue May 15, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Jun 27, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Jun 27, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Jul 4, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Jul 4, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Jul 4, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Jul 4, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Jul 4, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Jul 16, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Oct 4, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Oct 8, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
bruno-zanotti added a commit to adhoc-dev/product-pack that referenced this issue Oct 24, 2024
Packs totalized and non-detailed ignores the product pack list price
when computing the price.

This commit is a hack to keep the behavior of the modules before
this refactor.

More information in the issue OCA#169.
Copy link

github-actions bot commented Nov 3, 2024

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

1 participant