project_task_scheduling: Fix flake8 errors and fix unit test error

Author: ernestotejeda

project_task_assignment/models/project.py

@@ -54,10 +54,9 @@ def _compute_employee_ids(self):
     @api.depends('employee_id', 'date_start_assignation',
                  'date_stop_assignation')
     def _compute_scheduled(self):
-        for record in self:
-            record.scheduled = record.employee_id \
-                               and record.date_start_assignation \
-                               and record.date_stop_assignation
+        for rec in self:
+            start, stop = rec.date_start_assignation, rec.date_stop_assignation
+            rec.scheduled = rec.employee_id and start and stop
 
     @api.onchange('project_id')
     def _onchange_project_id_employee_id(self):

project_task_scheduling/models/project.py

@@ -1,5 +1,5 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-from odoo import api, fields, models
+from odoo import fields, models
 
 
 class Task(models.Model):

project_task_scheduling/models/project_task_scheduling_proposal.py

@@ -21,7 +21,9 @@ class ProjectTaskScheduling(models.TransientModel):
     delayed_tasks = fields.Float(
         compute='_compute_delayed_tasks'
     )
-    evaluation = fields.Float()
+    evaluation = fields.Float(
+        digits=(16,4)
+    )
     task_scheduling_ids = fields.One2many(
         comodel_name='project.task.scheduling',
         inverse_name='proposal_id',
@@ -98,4 +100,5 @@ def action_recompute(self):
                 'or Date start is far from the deadline of some tasks'))
 
         hours_dy += max_hours_delayed
-        self.evaluation = task_dy_count * max_hours_delayed * 2 + hours_dy
+        evaluation = task_dy_count * max_hours_delayed * 2 + hours_dy
+        self.evaluation = round(evaluation, 10)

project_task_scheduling/tests/test_scheduling_proposal.py

@@ -1,6 +1,4 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-from datetime import timedelta
-
 from odoo.addons.project_task_scheduling.tests.common import \
     TestSchedulingCommon
 
@@ -9,8 +7,8 @@ class TestSchedulingProposal(TestSchedulingCommon):
 
     def test_action_recompute(self):
         self.wizard.action_accept()
-        proposals = self.env['project.task.scheduling.proposal'].search([])
-        best_proposal = proposals[-1]
+        proposal_obj = self.env['project.task.scheduling.proposal']
+        best_proposal = proposal_obj.search([])[-1]
         evaluation = best_proposal.evaluation
         new_proposal = best_proposal.copy()
         new_proposal.action_recompute()