[MIG] project_task_material_stock: Migration to 10.0 #288

cubells · 2017-06-06T16:54:04Z

Update manifest file
Update tests

rafaelbn · 2017-06-08T23:41:34Z

Please @cubells review travis:

2017-06-07 07:28:36,528 6496 ERROR openerp_test odoo.addons.project_timesheet_currency.tests.test_multicurrency_timesheet: ERROR

rafaelbn

Tested in runbot:

Go to a task -> Edit -> go to tab materials in the task and try to add materiala -> It doesn't works

Please review

rafaelbn · 2017-06-08T23:43:00Z

project_task_material_stock/README.rst

+Contributors
+------------
+
+* Rafael Blasco <rafabn@antiun.com>


rafael.blasco@tecnativa.com

rafaelbn · 2017-06-08T23:43:19Z

project_task_material_stock/README.rst

+------------
+
+* Rafael Blasco <rafabn@antiun.com>
+* Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>


pedro.baeza@tecnativa.com

rafaelbn · 2017-06-08T23:43:30Z

project_task_material_stock/README.rst

+
+* Rafael Blasco <rafabn@antiun.com>
+* Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>
+* Carlos Dauden <carlos@incaser.es>


carlos.dauden@tecnativa.com

rafaelbn · 2017-06-08T23:43:39Z

project_task_material_stock/README.rst

+* Rafael Blasco <rafabn@antiun.com>
+* Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>
+* Carlos Dauden <carlos@incaser.es>
+* Sergio Teruel <sergio@incaser.es>


sergio.teruel@tecnativa.com

cubells · 2017-06-09T09:37:10Z

@rafaelbn fixed!

rafaelbn

Functionally tested 👍
Travis still fails, please review
Thanks!

cubells · 2017-06-13T19:08:33Z

@rafaelbn :
travis error is due to project_timesheet_currency module. Error is not related to this migration.

rafaelbn · 2017-06-14T00:02:41Z

I see, in #275 . Maybe is useful to ping @damdam-s @gurneyalex or @guewen to notice about travis error related to project_timesheet_currency module and the could make a PR to fix it.

About this PR, as said 👍

gurneyalex · 2017-06-14T06:31:01Z

@rafaelbn the error is not caused by project_timesheet_currency (Travis is green on 10.0 branch of this project).

This is a classic error which happens when in the repo you have 2 unrelated modules mod_a and mod_b. mod_b introduces a new required field on a model used by mod_a (e.g. security_lead on res.company, which in the current case is introduced by the dependency on sale_stock). mod_a does not depend on mod_b so the tests of mod_a may be run by travis before mod_b and its dependencies are loaded. However the MQT scripts have preinstalled the dependencies of all modules in the repository (in our case sale_stock). This means the new column is in database, with a NOT NULL constraint. But the default value is not provided when the record is created because sale_stock is not loaded in memory yet => broken CI.

Ways out of this:

make project_timesheet_currency depend on sale_stock (I'm 👎 on this)
split the tests in travis.yml to have the module depending on sale_stock tested separately from the ones who don't
change the offending tests in all modules not depending on sale_stock and creating a res.company to be decorated with at_install(False) and post_install(True) -> this will make these tests run after all the modules have been loaded.

I'm fine with the last two options, provided the change is made as part of this PR.

pedrobaeza · 2017-06-18T23:31:24Z

Thanks for the explanation @gurneyalex.

@cubells Please use method 3 in the tests of this module.

pedrobaeza

Plus the change in the test

pedrobaeza · 2017-06-18T23:32:01Z

project_task_material_stock/README.rst

+#. If you are a project manager, go to Project > Configuration > Stages and
+   check option 'Consume Material' in Task Stage to generate a stock move when
+   the task is in that stage.
+#. Go to Project -> Configuration - > Settings and enable option


Is this needed on 10.0?

pedrobaeza · 2017-06-18T23:32:27Z

project_task_material_stock/README.rst

+=====
+
+#. Go to a task, edit, and add materials to be consumed on tab "Materials".
+#. Move task to an stage on consume material are activated and moves and


s/on consume material are/where "Consume material" check is

pedrobaeza · 2017-06-18T23:32:45Z

project_task_material_stock/__manifest__.py

+               "record products spent in a Task",
+    "version": "10.0.1.0.0",
+    "category": "Project Management",
+    "author": "Antiun Ingeniería S.L.,"


Remove Antiun

pedrobaeza · 2017-06-18T23:33:17Z

project_task_material_stock/__manifest__.py

+              "Tecnativa, "
+              "Odoo Community Association (OCA)",
+    "license": "AGPL-3",
+    "application": False,


Add 'website' key and you can remove this one.

dreispt · 2017-08-09T14:13:34Z

@pedrobaeza There is a new commit, can you check?

… moves.

* Singleton unlink tasks * Several suggestions * PEP8 * Warning if invoiced lines and move to not consume stage

pedrobaeza

I have rebased the branch and everything is alright, so I merge.

cubells force-pushed the 10.0-mig-project_task_materials_stock branch from e687c63 to 9140838 Compare June 7, 2017 07:10

cubells changed the title ~~[MIG] project_task_materials_stock: Migration to 10.0~~ [MIG] project_task_material_stock: Migration to 10.0 Jun 7, 2017

rafaelbn added this to the 10.0 milestone Jun 8, 2017

rafaelbn added needs fixing needs review labels Jun 8, 2017

rafaelbn requested changes Jun 9, 2017

View reviewed changes

cubells force-pushed the 10.0-mig-project_task_materials_stock branch from 7eceb7a to 0859aff Compare June 9, 2017 09:38

rafaelbn requested changes Jun 12, 2017

View reviewed changes

cubells mentioned this pull request Jun 13, 2017

[MIG] project_task_materials_analytic_partner module: migration to 10.0 #290

Closed

2 tasks

rafaelbn approved these changes Jun 14, 2017

View reviewed changes

rafaelbn removed the needs fixing label Jun 14, 2017

cubells force-pushed the 10.0-mig-project_task_materials_stock branch 2 times, most recently from 65e864b to e863b2c Compare June 14, 2017 04:40

pedrobaeza requested changes Jun 18, 2017

View reviewed changes

cubells force-pushed the 10.0-mig-project_task_materials_stock branch 6 times, most recently from 3b7bbf5 to d15f05a Compare June 28, 2017 20:31

pedrobaeza mentioned this pull request Aug 9, 2017

Migration to version 10.0 #196

Closed

27 tasks

sergio-teruel and others added 2 commits August 9, 2017 16:28

project_task_materials_stock: New module to create stock and analytic…

c4141d2

… moves.

project_task_materials_stock: Various fixes

cfe3d96

* Singleton unlink tasks * Several suggestions * PEP8 * Warning if invoiced lines and move to not consume stage

oca-transbot and others added 7 commits August 9, 2017 16:28

OCA Transbot updated translations from Transifex

94c4f05

project_task_materials_stock module

1debb3e

OCA Transbot updated translations from Transifex

469472a

Add default locations to consume materials

93ac165

OCA Transbot updated translations from Transifex

18f4860

[IMP] project_task_materials_stock: add default locations to tasks

29a9f82

[MIG] project_task_materials_stock: Migration to 10.0

314f44c

pedrobaeza force-pushed the 10.0-mig-project_task_materials_stock branch from d15f05a to 314f44c Compare August 9, 2017 14:33

pedrobaeza approved these changes Aug 9, 2017

View reviewed changes

pedrobaeza merged commit c151087 into OCA:10.0 Aug 9, 2017

pedrobaeza deleted the 10.0-mig-project_task_materials_stock branch August 9, 2017 15:23

cubells mentioned this pull request Aug 23, 2017

10.0 mig project task material analytic partner #310

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] project_task_material_stock: Migration to 10.0 #288

[MIG] project_task_material_stock: Migration to 10.0 #288

cubells commented Jun 6, 2017

rafaelbn commented Jun 8, 2017

rafaelbn left a comment

rafaelbn Jun 8, 2017

rafaelbn Jun 8, 2017

rafaelbn Jun 8, 2017

rafaelbn Jun 8, 2017

cubells commented Jun 9, 2017

rafaelbn left a comment

cubells commented Jun 13, 2017

rafaelbn commented Jun 14, 2017

gurneyalex commented Jun 14, 2017 •

edited

Loading

pedrobaeza commented Jun 18, 2017

pedrobaeza left a comment

pedrobaeza Jun 18, 2017

pedrobaeza Jun 18, 2017

pedrobaeza Jun 18, 2017

pedrobaeza Jun 18, 2017

dreispt commented Aug 9, 2017

pedrobaeza left a comment

[MIG] project_task_material_stock: Migration to 10.0 #288

[MIG] project_task_material_stock: Migration to 10.0 #288

Conversation

cubells commented Jun 6, 2017

rafaelbn commented Jun 8, 2017

rafaelbn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cubells commented Jun 9, 2017

rafaelbn left a comment

Choose a reason for hiding this comment

cubells commented Jun 13, 2017

rafaelbn commented Jun 14, 2017

gurneyalex commented Jun 14, 2017 • edited Loading

pedrobaeza commented Jun 18, 2017

pedrobaeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreispt commented Aug 9, 2017

pedrobaeza left a comment

Choose a reason for hiding this comment

gurneyalex commented Jun 14, 2017 •

edited

Loading