Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] purchase_request: changes in report layout #2225

Merged
merged 1 commit into from
May 27, 2024

Conversation

ced-adhoc
Copy link
Contributor

@ced-adhoc ced-adhoc commented Apr 3, 2024

Rectify the layout of the purchase request report to address issues with column widths. Modifications include adjusting the Bootstrap grid classes for each column:

  • Request Reference, Creation Date, Source, Requested by, Assigned to, and Picking Type columns have been resized to col-2 to ensure uniformity and prevent overflow.
  • Description column has been resized to col-12 to occupy the entire width, resolving readability issues caused by its previous narrow width.
    This fix aims to provide a more coherent and user-friendly layout, enhancing the overall usability of the purchase request report.

Note: There is a Manual FP to this PR. Please find it here.

Copy link
Contributor

@florenciafrigieri2 florenciafrigieri2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok

@florenciafrigieri2
Copy link
Contributor

@pedrobaeza Hello Pedro, can you please check this PR?

Also the fwd port to 17: #2250

Thanks!

@pedrobaeza
Copy link
Member

Please put screeshots of the before and the after.

@florenciafrigieri2
Copy link
Contributor

@pedrobaeza sure!

Before:
image

After:
image

@pedrobaeza pedrobaeza added this to the 16.0 milestone May 27, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2225-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b32c469 into OCA:16.0 May 27, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0f6a796. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants