Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] purchase_order_type_dashboard #2260

Merged
merged 11 commits into from
May 8, 2024
Merged

[17.0][MIG] purchase_order_type_dashboard #2260

merged 11 commits into from
May 8, 2024

Conversation

Anxo82
Copy link

@Anxo82 Anxo82 commented Apr 30, 2024 •
edited
Loading

Standard migration

dalonsod and others added 10 commits April 30, 2024 17:19
@dalonsod @Anxo82
[ADD] purchase_order_type_dashboard
be1c3a3
@dalonsod @Anxo82
[IMP] purchase_order_type_dashboard: black, isort, prettier
05abdb8
@dalonsod @Anxo82
[MIG] purchase_order_type_dashboard: Migration to 14.0
7378e1c
@dalonsod @Anxo82
[IMP] purchase_order_type_dashboard: black, isort, prettier
0a183c5
@dalonsod @Anxo82
[MIG] purchase_order_type_dashboard: Migration to 15.0
7e015f6
@ChristianSantamaria @Anxo82
[MIG] purchase_order_type_dashboard: Migration to 16.0
a8b9bf7
@Ivorra78 @Anxo82
Translated using Weblate (Spanish)
ed8efc5 
Currently translated at 100.0% (17 of 17 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_type_dashboard
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_type_dashboard/es/
@OCA-git-bot @Anxo82
[UPD] README.rst
79b5cd3
@mymage @Anxo82
Added translation using Weblate (Italian)
097daca
@Anxo82
[IMP] purchase_order_type_dashboard: pre-commit auto fixes
c5324f8
@Anxo82 Anxo82 force-pushed the 17.0-mig-purchase_order_type_dashboard branch 2 times, most recently from 8ee4345 to 078ade2 Compare May 2, 2024 06:09
@dalonsod dalonsod force-pushed the 17.0-mig-purchase_order_type_dashboard branch from 078ade2 to 2e3ca1c Compare May 6, 2024 11:20
@Anxo82
Copy link
Author

Anxo82 commented May 6, 2024

@flalexg @HviorForgeFlow
Could you review?
Thanks

pmonje-duonex
pmonje-duonex suggested changes May 6, 2024
View reviewed changes
Copy link

@pmonje-duonex pmonje-duonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the kanban view, the vertical three dots button is not aligned with the title of the purchase type unlike in v16.

image

When clicking the button in v17 it doesnt show any option.

When clicking on "Nothing to bill" or "Waiting to bill" an error occurs and it does not filter the purchases.

@Anxo82 Anxo82 force-pushed the 17.0-mig-purchase_order_type_dashboard branch from 2e3ca1c to 45b04c9 Compare May 7, 2024 09:51
@Anxo82 Anxo82 force-pushed the 17.0-mig-purchase_order_type_dashboard branch from 45b04c9 to 74a06d2 Compare May 7, 2024 10:02
@Anxo82
Copy link
Author

Anxo82 commented May 7, 2024

@pmonje-duonex
Could you review?
Thanks

pmonje-duonex
pmonje-duonex approved these changes May 7, 2024
View reviewed changes
Copy link

@pmonje-duonex pmonje-duonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Functional review on runboat

@Anxo82 Anxo82 changed the title [17.0] [MIG] purchase order type dashboard [17.0][MIG] purchase_order_type_dashboard May 8, 2024
@ChristianSantamaria
Copy link
Contributor

/ocabot migration purchase_order_type_dashboard

@OCA-git-bot
Copy link
Contributor

Sorry @ChristianSantamaria you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@HviorForgeFlow
Copy link
Member

/ocabot migration purchase_order_type_dashboard

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 8, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 8, 2024
Open
49 tasks
HviorForgeFlow
HviorForgeFlow approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@HviorForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-2260-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit fe59a06 into OCA:17.0 May 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1662c5c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmonje-duonex pmonje-duonex pmonje-duonex approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Anxo82 @ChristianSantamaria @OCA-git-bot @HviorForgeFlow @pmonje-duonex @dalonsod @Ivorra78 @mymage