-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0][MIG] product_by_supplier #361
Conversation
cc @eficent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little redaction bugs.
product_by_supplier/README.rst
Outdated
This module add a new menu item 'Product by suppliers' in Purchases -> Products. | ||
It allows for users to be able to view a compiled list of products supplied by the supplier. | ||
This information is the corresponding to the supplier list on each product. | ||
This module add a new menu item 'Product by suppliers' in Purchases -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/add/adds
product_by_supplier/README.rst
Outdated
It allows for users to be able to view a compiled list of products supplied by the supplier. | ||
This information is the corresponding to the supplier list on each product. | ||
This module add a new menu item 'Product by suppliers' in Purchases -> | ||
Products. It allows for users to be able to view a compiled list of products |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove for
product_by_supplier/README.rst
Outdated
This information is the corresponding to the supplier list on each product. | ||
This module add a new menu item 'Product by suppliers' in Purchases -> | ||
Products. It allows for users to be able to view a compiled list of products | ||
supplied by the supplier. This information is the corresponding to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/the supplier/their supplier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've attended these mistakes.
[11.0] product_brand: complete fr translation
The changes included in this migration are: