Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][10.0] purchase_last_price_info #587

Closed
wants to merge 5 commits into from

Conversation

Abranes
Copy link
Member

@Abranes Abranes commented Sep 20, 2018

As I didn't get an answer in #406 here, the migration to 10.0

@JayVora-SerpentCS
Copy link

@kittiu please check. Its not helpful to have 2 PRs for the same concept.

@Abranes
Copy link
Member Author

Abranes commented Nov 29, 2018

Someone tested?

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

purchase_last_price_info/models/product.py Outdated Show resolved Hide resolved
@Abranes Abranes force-pushed the 10.0_mig_purchase_last_price_info branch from 3935dc9 to 55053cc Compare December 4, 2018 10:41
@Abranes
Copy link
Member Author

Abranes commented Dec 4, 2018

If anyone can help me, I don't know why travis fail, there is no error with my module and runbot is ok.

@pedrobaeza
Copy link
Member

It is in your module:

purchase_last_price_info/__manifest__.py:13:80: E501 line too long (93 > 79 characters)

@Abranes
Copy link
Member Author

Abranes commented Dec 4, 2018

Thank you @pedrobaeza, I didn't see it 😓

@pedrobaeza
Copy link
Member

OK, no problem. I have to admit it's very hidden between the rest of the log lines.

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test, LGTM.

@CasVissers-360ERP
Copy link

Only thing I would fix is the ability to handle multicurrency companies. The last price doesn't take the PO currency into account.

@CasVissers-360ERP
Copy link

In addition ('product_id', '=', self.id), should be ('product_id', '=', product.id),

@github-actions
Copy link

github-actions bot commented Jul 3, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 3, 2022
@github-actions github-actions bot closed this Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants