-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][10.0] purchase_last_price_info #587
Conversation
@kittiu please check. Its not helpful to have 2 PRs for the same concept. |
Someone tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a2cf5f5#diff-0deeef207fc91d4de1cf837a9fb5412eR13
website
URL as per this
3935dc9
to
55053cc
Compare
If anyone can help me, I don't know why travis fail, there is no error with my module and runbot is ok. |
It is in your module:
|
Thank you @pedrobaeza, I didn't see it 😓 |
OK, no problem. I have to admit it's very hidden between the rest of the log lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test, LGTM.
Only thing I would fix is the ability to handle multicurrency companies. The last price doesn't take the PO currency into account. |
In addition ('product_id', '=', self.id), should be ('product_id', '=', product.id), |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
As I didn't get an answer in #406 here, the migration to 10.0