[13.0] Add method to patch a method to be automatically delayed #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guewen
force-pushed
the
13.0-job-patch-auto-delay
branch
from
eca59b2
to
f08db77
Compare
guewen
added a commit
to camptocamp/ddmrp
that referenced
this pull request
Nov 2, 2020
It makes every calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
This was referenced Nov 2, 2020
guewen
added a commit
to camptocamp/ddmrp
that referenced
this pull request
Nov 2, 2020
It makes every calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
|
TODO: Currently, the patched method is automatically delayed and can be forced to be synchrone with a context key. We should probably make it explicit by expecting a key in the context to use autodelay: if someone calls the method elsewhere, and expect to have the computation of the method to be done synchronously, having a delay fully automatic can introduce silent and vicious errors. |
guewen
force-pushed
the
13.0-job-patch-auto-delay
branch
2 times, most recently
from
b0aca1e
to
de019cc
Compare
guewen
added a commit
to camptocamp/ddmrp
that referenced
this pull request
Nov 2, 2020
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
guewen
force-pushed
the
13.0-job-patch-auto-delay
branch
2 times, most recently
from
cd01fd1
to
8a5234d
Compare
guewen
added a commit
to camptocamp/ddmrp
that referenced
this pull request
Nov 2, 2020
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
|
@guewen is this PR still a draft? |
This patch method has to be called in ``_register_hook``. When a method is patched, any call to the method will not directly execute the method's body, but will instead enqueue a job. When a ``context_key`` is set when calling ``_patch_job_auto_delay``, the patched method is automatically delayed only when this key is ``True`` in the caller's context. It is advised to patch the method with a ``context_key``, because making the automatic delay *in any case* can produce nasty and unexpected side effects (e.g. another module calls the method and expects it to be computed before doing something else, expecting a result, ...). A typical use case is when a method in a module we don't control is called synchronously in the middle of another method, and we'd like all the calls to this method become asynchronous. It relies on OCA#274 that deprecates the `@job` decorator.
guewen
force-pushed
the
13.0-job-patch-auto-delay
branch
from
8a5234d
to
44cd716
Compare
|
note to myself: worth to add a doc in readme |
sebastienbeau
approved these changes
Nov 20, 2020
simahawk
approved these changes
Jan 26, 2021
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 8fe68a4. Thanks a lot for contributing to OCA. ❤️ |
guewen
added a commit
to camptocamp/ddmrp
that referenced
this pull request
Feb 2, 2021
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
guewen
added a commit
to camptocamp/ddmrp
that referenced
this pull request
Feb 2, 2021
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
guewen
added a commit
to camptocamp/ddmrp
that referenced
this pull request
Feb 3, 2021
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
guewen
added a commit
to camptocamp/ddmrp
that referenced
this pull request
Feb 3, 2021
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
guewen
added a commit
to camptocamp/ddmrp
that referenced
this pull request
Feb 3, 2021
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
DavidBForgeFlow
pushed a commit
to ForgeFlow/ddmrp
that referenced
this pull request
Mar 17, 2021
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
DavidBForgeFlow
pushed a commit
to ForgeFlow/ddmrp
that referenced
this pull request
Mar 19, 2021
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
DavidBForgeFlow
pushed a commit
to ForgeFlow/ddmrp-1
that referenced
this pull request
Mar 19, 2021
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
Merged
DavidBForgeFlow
pushed a commit
to ForgeFlow/ddmrp
that referenced
this pull request
May 27, 2021
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
ChrisOForgeFlow
pushed a commit
to ForgeFlow/ddmrp
that referenced
this pull request
Dec 16, 2021
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
JordiBForgeFlow
pushed a commit
to OCA/ddmrp
that referenced
this pull request
Feb 18, 2022
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
BernatPForgeFlow
pushed a commit
to ForgeFlow/ddmrp
that referenced
this pull request
Jun 6, 2023
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
LoisRForgeFlow
pushed a commit
to ForgeFlow/ddmrp-1
that referenced
this pull request
Mar 11, 2024
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
patrickrwilson
pushed a commit
to ursais/ddmrp
that referenced
this pull request
Apr 18, 2024
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
Vandan-OSI
pushed a commit
to ursais/ddmrp
that referenced
this pull request
May 6, 2024
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
DavidJForgeFlow
pushed a commit
to ForgeFlow/ddmrp-1
that referenced
this pull request
Jun 13, 2024
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
ArnauCForgeFlow
pushed a commit
to ForgeFlow/ddmrp
that referenced
this pull request
Jul 18, 2024
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
ArnauCForgeFlow
pushed a commit
to ForgeFlow/ddmrp-1
that referenced
this pull request
Jul 18, 2024
It makes calls to "cron_actions" run in queue jobs. The jobs have an identity key with "identity_exact", meaning that only one occurence of a job for the same buffer with the same arguments (only_nfp) will be created at a time (e.g. when the state of a stock.move is changed several times in the same transaction or in a different transaction in a short timeframe). It needs OCA/queue#274 and OCA/queue#275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch method has to be called in
_register_hook.When a method is patched, any call to the method will not directly
execute the method's body, but will instead enqueue a job.
When a
context_keyis set when calling_patch_job_auto_delay,the patched method is automatically delayed only when this key is
Truein the caller's context. It is advised to patch the methodwith a
context_key, because making the automatic delay in anycase can produce nasty and unexpected side effects (e.g. another
module calls the method and expects it to be computed before doing
something else, expecting a result, ...).
A typical use case is when a method in a module we don't control is called
synchronously in the middle of another method, and we'd like all the calls
to this method become asynchronous.
It relies on #274 that deprecates the
@jobdecoratorReplaces #270
Closes #238