Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate v11 queue job subscribe #31

Merged
merged 2 commits into from
Dec 13, 2017
Merged

Migrate v11 queue job subscribe #31

merged 2 commits into from
Dec 13, 2017

Conversation

guewen
Copy link
Member

@guewen guewen commented Oct 3, 2017 •
edited by lepistone
Loading

Depends of #30

@pedrobaeza pedrobaeza mentioned this pull request Oct 3, 2017
Closed
3 tasks
gdgellatly
gdgellatly approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@gdgellatly gdgellatly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guewen I only reviewed files in these commits https://github.com/OCA/queue/pull/31/files/85af69bf6cc064243aff0756848d28b2116297d1..6eac2b205d4db38afb8551d8306a8ee3ab9e0897 .

In terms of the port it looks fine, obviously its a simple one, although I noticed in res_users that we have Jobs Notifications as the string. To be honest I don't know if its right or not, but looks wrong given the help string refers to Job Notifications.

@lepistone lepistone force-pushed the migrate-v11-queue_job_subscribe branch from 6eac2b2 to 153ab8f Compare October 3, 2017 13:13
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 153ab8f on guewen:migrate-v11-queue_job_subscribe into ** on OCA:11.0**.

@guewen
Copy link
Member Author

guewen commented Oct 3, 2017

@gdgellatly Thanks! I added a fixup commit, changing the string to "Job Notifications". I don't know either which was correct but at least it's consistent.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 12d1328 on guewen:migrate-v11-queue_job_subscribe into ** on OCA:11.0**.

@lepistone lepistone force-pushed the migrate-v11-queue_job_subscribe branch from 12d1328 to aebcdaf Compare October 3, 2017 14:52
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 78.283% when pulling aebcdaf on guewen:migrate-v11-queue_job_subscribe into e1c07cc on OCA:11.0.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 31, 2017
simahawk
simahawk approved these changes Dec 11, 2017
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runbot build re-triggered

@guewen guewen merged commit 8e6ed26 into OCA:11.0 Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@lepistone lepistone lepistone approved these changes

@atchuthan atchuthan atchuthan approved these changes

@gdgellatly gdgellatly gdgellatly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
7 participants
@guewen @coveralls @simahawk @lepistone @atchuthan @gdgellatly @pedrobaeza