[14.0][PORT] queue_job_cron_jobrunner: backport from 15.0 to 14.0 for queue_job_cron_jobrunner from 15.0 to 14.0 #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisb-c01
force-pushed
the
14.0-backport-queue_job_cron_jobrunner
branch
6 times, most recently
from
5c561df
to
b13c602
Compare
|
Hi @chrisb-c01, thanks! |
chrisb-c01
force-pushed
the
14.0-backport-queue_job_cron_jobrunner
branch
from
b13c602
to
9513d9d
Compare
I've added the commit. Getting a pre-commit failure now but it seems to be an issue with pre-commit/Python. |
|
It seems to be solved or a transient issue, re-running the check gave a successful run. Thanks! |
guewen
approved these changes
Nov 2, 2022
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c849a31. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of the
queue_job_cron_jobrunneradded in 15.0 branch to 14.0.Because 15.0 uses
ir.cron.triggerto schedule cron jobs through thecron._trigger(at)private method, in this backport I am 'just' setting thecron.nextcallattribute to the current timedatetime.now()in[queue.job]._cron_trigger().