Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] queue_job_cron_jobrunner #604

Merged

Conversation

sanderlienaerts
Copy link

@sanderlienaerts sanderlienaerts commented Dec 1, 2023

depends on #593

@sanderlienaerts sanderlienaerts force-pushed the 17.0-mig-queue_job_cron_jobrunner branch from c24611b to b9722f9 Compare December 6, 2023 10:21
@sanderlienaerts
Copy link
Author

Force pushed last commit since #593 (queue_job) was merged into 17.0, now all checks pass

@gurneyalex
Copy link
Member

/ocabot migration queue_job_cron_jobrunner

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 12, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 12, 2023
8 tasks
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-604-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 12, 2023
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-604-by-gurneyalex-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-604-by-gurneyalex-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sbidoul
Copy link
Member

sbidoul commented Dec 12, 2023

Same pre-commit error as in the other PR... that's new. I'll investigate.

@sbidoul
Copy link
Member

sbidoul commented Dec 12, 2023

We are likely hitting pypa/hatch#1129. The appearance of this problem coincides with the release of hatchling 1.19.

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-604-by-gurneyalex-bump-nobump, awaiting test results.

@gurneyalex
Copy link
Member

Fix in hatch 1.9.1 I'm restarting the merge

@OCA-git-bot OCA-git-bot merged commit 4827b13 into OCA:17.0 Dec 13, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5b7a26f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants