Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][FIX]queue_job: search jobs with same identity key must be done with sudo() #92

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

Cedric-Pigeon
Copy link

When doing a search, it must be done in sudo() otherwise users which are not in the group Job Queue Manager will get a security error.
It can occurs when process launch a job throug a .delay instruction.

@Cedric-Pigeon
Copy link
Author

@lmignon @sebastienbeau This is required for shopinvader. If a user triggers a stock export, he will get an error if he is not in the Job Queue Manager group.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.658% when pulling 3955f77 on acsone:10.0-identity_job_sudo-cpi into 662782b on OCA:10.0.

@sebastienbeau
Copy link
Member

👍 you're right this should be done with sudo

@sebastienbeau sebastienbeau merged commit 9d107d6 into OCA:10.0 Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants