Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] Forward port. changes about identity_key (on queue_job) #99

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

acsonefho
Copy link

@acsonefho acsonefho commented Sep 25, 2018

@acsonefho acsonefho changed the title [11.0] Forward port. of identity_key (from 10.0) + minor changes for … [11.0] Forward port. changes about identity_key (on queue_job) Sep 25, 2018
@lmignon
Copy link
Contributor

lmignon commented Sep 25, 2018

@acsonefho It would be nice to forward port all the changes in 10.0 not yet into 11.0 For #66 you must also include 3955f77

@acsonefho acsonefho force-pushed the 11.0_forward_port_identity_key_queue_job branch from c1d9854 to 339bf6c Compare September 25, 2018 08:43
@acsonefho
Copy link
Author

acsonefho commented Sep 25, 2018

@acsonefho It would be nice to forward port all the changes in 10.0 not yet into 11.0 For #66 you must also include 3955f77

@lmignon It's maybe better to include others changes into new MR (1 per "feature"/improvement: easier to understand what is forwarded, easier to review and in case of big issue, easier to revert only 1 feature).
What do you think?
(I just include the commit that I forget into this MR)

'installable': True,
'development_status': 'Mature',
'maintainers': ['guewen'],
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you really need to change the format here and in some other places? AFAIK both styles are accepted and changing them can create new conflicts when porting changes between versions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guewen Thank you for your advice, it should be ok now

@acsonefho acsonefho force-pushed the 11.0_forward_port_identity_key_queue_job branch from 339bf6c to 6c1fedb Compare October 1, 2018 09:46
@acsonefho acsonefho force-pushed the 11.0_forward_port_identity_key_queue_job branch from 6c1fedb to d442345 Compare October 1, 2018 12:05
Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@guewen guewen merged commit 518d626 into OCA:11.0 Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants