-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0] Forward port. changes about identity_key (on queue_job) #99
[11.0] Forward port. changes about identity_key (on queue_job) #99
Conversation
acsonefho
commented
Sep 25, 2018
•
edited
Loading
edited
- Forward port. of [10.0] Add identity key on job to allow limiting redundant execution #66 (and fix conflicts);
- Minor changes for Flake/Pylint;
- Tests pass (using test_queue_job);
@acsonefho It would be nice to forward port all the changes in 10.0 not yet into 11.0 For #66 you must also include 3955f77 |
c1d9854
to
339bf6c
Compare
@lmignon It's maybe better to include others changes into new MR (1 per "feature"/improvement: easier to understand what is forwarded, easier to review and in case of big issue, easier to revert only 1 feature). |
queue_job/__manifest__.py
Outdated
'installable': True, | ||
'development_status': 'Mature', | ||
'maintainers': ['guewen'], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you really need to change the format here and in some other places? AFAIK both styles are accepted and changing them can create new conflicts when porting changes between versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guewen Thank you for your advice, it should be ok now
339bf6c
to
6c1fedb
Compare
6c1fedb
to
d442345
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!