-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Printer copies #88
Printer copies #88
Conversation
Please rename module to printer_copy_number, for not using plurals in module name as stated in OCA guidelines. |
I renamed it |
Thanks! |
great feature.. lets merge it ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some unit tests and a README.rst
.
Travis errors:
printer_copy_number/__init__.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
printer_copy_number/__manifest__.py:3: [C8103(manifest-deprecated-key), ] Deprecated key "description" in manifest file
class ResUsers(models.Model): | ||
_inherit = "res.users" | ||
|
||
copies = fields.Integer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer this field to be named print_copy_count
or something like that, as the users model is very generic, copies
could be anything.
@@ -0,0 +1,18 @@ | |||
<?xml version="1.0"?> | |||
<openerp> | |||
<data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace openerp
and data
nodes by a single odoo
node.
@@ -0,0 +1,25 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<openerp> | |||
<data noupdate="0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace openerp
and data
nodes by a single odoo
node.
Specifying noupdate="0"
is not needed (but not a problem).
@@ -0,0 +1,30 @@ | |||
<?xml version="1.0"?> | |||
<openerp> | |||
<data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace openerp
and data
nodes by a single odoo
node.
@jeanpaulrobineau can you take another look at this PR ? |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Hello,
This module will allow to specify per report or user/report the number of copies.
This is inspired by printer_tray module
kind regards,
Jean-Paul Robineau