[FIX] report_py3o: fix exception when report must be saved as attache… #100
Conversation
…ment The mehtod must be called with a list of ids not with a list of browse records
|
I proposed another fix for report_py3o as a PR to this branch: |
…feature now working with py3o)
lmignon
force-pushed
the
10.0-fix_report_py3o_save_attachment-lmi
branch
from
dda8dfc
to
8b1954e
Compare
|
We really need someone to merge this ! |
|
@lmignon Do you now have commit rights to merge this (following my email on the OCA ML) ? |
|
@alexis-via No I don't have the rights to merge this one.... It's hard to have a dynamic management of this addon when we have to wait for weeks to have a PR merged. |
|
@lmignon You mean you still don't have commit rights on OCA/reporting-engine ? |
Yes that's what I mean. I don't have commit rights on OCA |
|
@elicoidal Thanks for your merge ! Could you add commit rights on this project to Laurent Mignon and Florent Aide as discussed in the OCA mailing-list ? |
|
@elicoidal @alexis-via actually, reporting-engine is under the tools PSC (like server-tools and others) so that means adding @lmignon and @faide in that group. Not that it would be a problem for me but... If you don't mind I'll do a small experiment and create a Reporting Engine Maintainers group and see if the OCA sync magic does the job. Actually as I read the code it should and it would be a step toward finer grained repo management. |
|
@faide I don't find you in the OCA database. Do you remember having sent your signed CLA? |
|
Yes i'm 100% positive on that and i received à confirmation i forwarded to
Laurent mignon
I can find it tomorrow if necessary
Le 16 mars 2017 5:25 PM, "Stéphane Bidoul (ACSONE)" <
notifications@github.com> a écrit :
… @faide <https://github.com/faide> I don't find you in the OCA database.
Do you remember having sent your signed CLA?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeL8Xuo0L95ZCMysGkWNx_vGEjLnhmnks5rmWKRgaJpZM4MJtvC>
.
|
|
@faide ok, I found it. Let's see if https://github.com/orgs/OCA/teams/reporting-engine-maintaners gets populated during the night. |
👍 |
|
@sbidoul It seems it didn't get updated during the night... |
|
@gurneyalex can you check why https://github.com/orgs/OCA/teams/reporting-engine-maintaners is not synchronized from https://odoo-community.org/web#id=112&view_type=form&model=project.project&menu_id=370&action=469 I think the |
|
Hello, It's a configuration issue: there was a typo in the team name in github ("Reporting Engine Maintaners") -> the matching was failing in the script. I'm fixing this. |
|
@faide you should have received an invitation to join the github team. Can you confirm? |
|
I have received an invitation yes
…On Tue, Mar 21, 2017 at 9:04 AM, Alexandre Fayolle ***@***.*** > wrote:
@faide <https://github.com/faide> you should have received an invitation
to join the github team. Can you confirm?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeL8Yhv4oLodLY51wWSZY2AQnc7f2Utks5rn4ScgaJpZM4MJtvC>
.
|
|
Thanks @gurneyalex ! |
|
@gurneyalex Thanks for solving this problem ! It will be a big help for the work on py3o in the OCA. |
…port_due_list [MIG] account_invoice_report_due_list: Migration to 12.0
…ment
The mehtod must be called with a list of ids not with a list of browse records
cc @alexis-via @JonathanNEMRY @rousseldenis