Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] report_qweb_parameter: Migration to 12.0 #301

Merged

Conversation

julianram
Copy link

Preserved commit history

Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just squash your last commit please!

@jarroyomorales
Copy link

ping @etobella

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Attend @jarroyomorales comments and all will be perfect 😄
@pedrobaeza should we superseed #281 for this PR?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jul 3, 2019
@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Rebased to 12.0-ocabot-merge-pr-301-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 3, 2019
16 tasks
@OCA-git-bot OCA-git-bot merged commit cbd3464 into OCA:12.0 Jul 3, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a09d173. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

OCA-git-bot added a commit that referenced this pull request Jul 3, 2019
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants