Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] added add-on pdf_compression / pdfa #60

Closed
wants to merge 1 commit into from

Conversation

Benniphx
Copy link

This addon provides the ability to convert outgoing and imported PDF attachments. You can compress the PDFs to save space in you database or file system. Also the possibility exists to convert PDFs in PDF/A

moved pull request from OCA/server-tools#474

Installation
============

#. You need at least Gostscript 9.18 (I recommend 9.19)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Gostscript/Ghostscript

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put the ghostscript executable as external dependency in the manifest file.

@dreispt dreispt added this to the 8.0 milestone Jul 19, 2016
input_file = f1.name
output_file = f2.name

if pdfa_option != 'no' and (report_override == 'default' or
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see pdfa_option or report_override changing between this if and the previous, so you could probably remove the first two conditionals because we already have confirmed above.

@lasley
Copy link

lasley commented Aug 12, 2016

Thanks for the awesome new module @Benniphx ! I have added some comments inline.

Also, we're adding a decent amount of core logic here without test coverage. Would you mind adding some more tests too please?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 24, 2021
@github-actions github-actions bot closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs fixing stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants