Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] report_py3o #73

Closed
wants to merge 118 commits into from
Closed

[9.0] report_py3o #73

wants to merge 118 commits into from

Conversation

faide
Copy link
Contributor

@faide faide commented Oct 4, 2016

This is the result of OCA days work in the "Open Document Reporting Workgroup"

We will add unit tests on this PR later on

The companion document is available here: https://docs.google.com/spreadsheets/d/1YgniNHjEWDHXZkhYWwasxmIklW734TL143euQ2Sjepc/

@lmignon
Copy link
Contributor

lmignon commented Oct 10, 2016

@faide Can you provide a CLA for the following commiters? http://odoo-community.org/page/website.cla

Vincent Lhote-Hatakeyama (no github login found)
@anael-lorimier (login unknown in OCA database)
@brmasson (login unknown in OCA database)
@faide (login unknown in OCA database)
@alexbrun (login unknown in OCA database)
@szekawong (login unknown in OCA database)

@lasley
Copy link

lasley commented Oct 10, 2016

Rebuilding Runbot now that dependencies have been installed

@lasley lasley added this to the 9.0 milestone Oct 10, 2016
@chermed
Copy link

chermed commented Oct 10, 2016

Can someone explain to us : what is the difference between Aeroo And py3o ?

@lmignon
Copy link
Contributor

lmignon commented Oct 11, 2016

@chermed Basically the 2 modules provides the same functionalities... (see https://docs.google.com/spreadsheets/d/1YgniNHjEWDHXZkhYWwasxmIklW734TL143euQ2Sjepc/edit#gid= for details)
Nevertheless thanks to XCG report_py3o is proposed to be included under the OCA umbrella. Besides being a clean and well-tested module, the inclusion under the OCA umbrella ensures that the module will continue to evolve across the Odoo versions and the community will have the opportunity to contribute to its development.

@alexis-via
Copy link
Contributor

I made a PR with the installation procedure in README faide#12

9.0 report_py3o: full installation procedure in README
@alexis-via
Copy link
Contributor

For me, this PR should be merged now (if the CLAs have been signed).

@alexis-via
Copy link
Contributor

@faide During the code sprint, we managed to call the display_address() method in py3o with

py3o://function="display_address(o.partner_id)"

but the carriage returns were not taken into account in the ODT file. For example, the current result is:

35B rue Montgolfier 69100 VILLEURBANNE France

with everything on the same line. Do you have an idea how we could fix that ? It makes the method display_address almost unusable in py3o for the moment...

@eLBati
Copy link
Member

eLBati commented Oct 26, 2016

Thanks for this work.

I am testing it and wondering how to avoid an empty field to be printed as False
How can I print an empty string?

@lasley
Copy link

lasley commented Oct 26, 2016

Changes LGTM.

Once @elicoidal confirms good as well, can you please squash the logical commits - specifically making sure to change the commit message on the one that tags me (2fbbdc9). Commit messages that tag users will spam them indefinitely 😦

@eLBati
Copy link
Member

eLBati commented Oct 28, 2016

Thanks @alexis-via for the answer https://twitter.com/alexisdlattre/status/791750379377754113

For now, we can anyway use the if py3o syntax
👍

@JosDeGraeve
Copy link

Hi,

I have tested the p3o reporting engine and git it up and running in practically no time. Good work !

For reports there is a flag "is_local_fusion". I'm a bit confused by this. In order to generate a PDF report, an external py3o server is needed for 'fusion/renderserver/oooserver'. However, with an external fusion, it is not possible to call odoo methods: that is a big restriction.

Why is it not possible to have the fusion part done on the odoo side + have the conversion step to PDF or other formats done by the rendering server ?

A feature that aeroo reports had, was to generate multiple reports separately. This allowed, for example, to print multiple invoices in a single run, but with each invoice generated in a separate document. If you need per-document page numbering, or want to eliminate nasty page alignment issues between documents, this feature comes very handy. Would it be hard to implement such a feature ?

Last question is how are translations handled ? I can't find any info on that.

Tnx

@lmignon
Copy link
Contributor

lmignon commented Nov 1, 2016

@JosDeGraeve the flag 'is_local_fusion' is to use if you want to be able to call methods from your templates. The rendition and the fusion are 2 separates steps. Even if you select the local fusion you can specify a py3o server to render your template into pdf or doc.

@sbidoul sbidoul changed the title report_py3o [9.0] report_py3o Nov 15, 2016
@scigghia
Copy link

hi, i've read documentation and source, but i need an example report module to study
is there?

@JosDeGraeve
Copy link

@scigghia for documentation, take a look at http://py3otemplate.readthedocs.io/en/latest/
As small sample doc can be found in demo/res_user.odt

@lmignon
Copy link
Contributor

lmignon commented Nov 23, 2016

@lmignon
Copy link
Contributor

lmignon commented Dec 19, 2016

A refactoring is proposed #78 (comment)

@oca-clabot
Copy link

Hey @faide,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 24, 2021
@github-actions github-actions bot closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.