Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] datamodel: replace deprecated use of "missing" argument #199

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

davejames
Copy link
Member

Deprecated use of "missing" argument leads to a warning in the Odoo logs when tests are run. This PR replaces "missing" with "load_default" as introduced in marshmallow-code/marshmallow#1742

@davejames
Copy link
Member Author

pre-commit is failing because apispec is included in the external_dependencies in multiple places both with and without a version

image

I think it's outside the scope of this PR and I'm not sure what the best approach to deal with it is. I think the requirements.txt file is fine as it is

@simahawk
Copy link
Contributor

simahawk commented Oct 4, 2021

pre-commit is failing because apispec is included in the external_dependencies in multiple places both with and without a version

image

I think it's outside the scope of this PR and I'm not sure what the best approach to deal with it is. I think the requirements.txt file is fine as it is

this is caused by #195 which should be rolled back because of this explanation acsone/setuptools-odoo#59

Feel free to revert it here.

simahawk
simahawk previously approved these changes Oct 4, 2021
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

@simahawk simahawk dismissed their stale review October 4, 2021 11:42

dismiss as build is not green yet

@davejames
Copy link
Member Author

thanks @simahawk I've gone ahead and committed the auto-generated requirements.txt

@simahawk
Copy link
Contributor

simahawk commented Oct 4, 2021

@davejames no big deal in this case but next time use git revert $hash 😉

@lmignon
Copy link
Contributor

lmignon commented Oct 8, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-199-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9d7d00f into OCA:14.0 Oct 8, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3694d28. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants