-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.0 mig crm rma location #130
Conversation
Hey @pragyachhabra, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. Some OCA formalism to adapt.
'version': '11.0.1.0.0', | ||
'author': "Vauxoo, Odoo Community Association (OCA)", | ||
'license': 'AGPL-3', | ||
'website': 'http://www.camptocamp.com,http://www.vauxoo.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this entry following https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py
'author': "Vauxoo, Odoo Community Association (OCA)", | ||
'license': 'AGPL-3', | ||
'website': 'http://www.camptocamp.com,http://www.vauxoo.com', | ||
'category': 'Generic Modules/CRM & SRM', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set this to one existing to appear correctly in https://odoo-community.org/shop
@@ -0,0 +1,3 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove void lines
@@ -0,0 +1,71 @@ | |||
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add readme fragments that will generate correctly this README file ?
https://github.com/OCA/maintainer-tools/tree/master/template/module/readme
@pragyachhabra you can pick 5782a35 to attend requested chnges |
@pragyachhabra Do you plan to finish this ? |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
I have upgraded version 11