Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][12.0] product_warranty #142

Merged
merged 29 commits into from
Apr 29, 2019
Merged

[MIG][12.0] product_warranty #142

merged 29 commits into from
Apr 29, 2019

Conversation

murtuzasaleh
Copy link
Member

Product Warranty

manu and others added 28 commits April 23, 2019 13:31
@murtuzasaleh
[INIT] crm_claim_rma & product_warranty
3f954fa
@murtuzasaleh
Added security rights for product_warranty
e826d62
@murtuzasaleh
[UPDATE]
cf36080
@bguillot @murtuzasaleh
[IMP] product_warranty: add waranty_return_address on the product_sup…
8f2407e 
…plierinfo
@sebastienbeau @murtuzasaleh
[FIX] product_waranty : fix syntax error
edc88c0
@murtuzasaleh
[UPDATE] website
ff2a6a7
@murtuzasaleh
[ADD] Spanish translation for crm_claim_rma and product_warranty
073f0d2
@bealdav @murtuzasaleh
[FIX] fix security rule syntax in crm_claim_rma and product warranty
6a78cd0
@murtuzasaleh
[IMP] 7.0 initial version
239e0f6
@murtuzasaleh
[UPD] Remove references to res.partner.address
99c7c5f
@jgrandguillaume @murtuzasaleh
[IMP] Clean the product waranty module (PEP8) + remove use of brand a…
dfb6a11 
…s it seems to be lost in another module that is not here
@guewen @murtuzasaleh
[FIX] crm_claim.date is a datetime, error when a product has no suppl…
b706285 
…ier, in such case, returns the product to the company's address
@murtuzasaleh
Launchpad automatic translations update.
3d957f5
@jgrandguillaume @murtuzasaleh
Clean a bit of PEP8 things
3efdc2a
@murtuzasaleh
[PRT] Move modules to __unported__ for 8.0 branch creation
eff0d76
@mistotebe @murtuzasaleh
[IMP] Port product_warranty
44c43dc
@murtuzasaleh
[IMP] product_warranty module is migrated to API 8.0 and odoo 8.0
12cbd2a
@nhomar @murtuzasaleh
[FIX] typo on comment being refered to an unexistent field.
74fd417
@sbidoul @murtuzasaleh
[UPD] prefix versions with 8.0
73f316e
@pedrobaeza @murtuzasaleh
[MIG] Make modules uninstallable
7b17113
@murtuzasaleh
product_warranty: migration V9
df6ab39
@murtuzasaleh
[FIX] file naming of view files
037aafb
@pedrobaeza @murtuzasaleh
[MIG] Make modules uninstallable
3204b37
@bimajatiwijaya @murtuzasaleh
Migrate to v10.0
4e64f16 
- Add dependency sale because group "group_sale_salesman" and "group_sale_manager" are defined on modul sales_team
  * sale depend to sales_team
  * update ir.model.access base. -> sales_team.
- Fix product.prod_config_main not compatible and moved to sale.prod_config_main
- Make removed col="6 when add product supplier info field too small (width)
@sbidoul @murtuzasaleh
remove obsolete .pot files [ci skip]
ce6006b
@osi-scampbell @murtuzasaleh
[MIG] Migrate product_warranty to 11.0
b2604fa
@OCA-git-bot @murtuzasaleh
[UPD] README.rst
c8a40bd
@OCA-git-bot @murtuzasaleh
[ADD] icon.png
9c13fdb
@murtuzasaleh
Copy link
Member Author

@max3903 @osi-scampbell Can you Please review this PR.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Apr 23, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 23, 2019
Closed
3 tasks
tbaden
tbaden approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
i did a code review: lgtm

maybe some aesthetic changes (see below), but not blocking

product_warranty/views/product_warranty.xml Outdated Show resolved Hide resolved
product_warranty/views/product_warranty.xml Outdated Show resolved Hide resolved
product_warranty/views/product_warranty.xml Outdated Show resolved Hide resolved
product_warranty/views/product_warranty.xml Outdated Show resolved Hide resolved
@rousseldenis rousseldenis mentioned this pull request Apr 29, 2019
Merged
rousseldenis
rousseldenis approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

@murtuzasaleh Is this one ready ?

@murtuzasaleh
Copy link
Member Author

Is this one ready ?

Yes

@rousseldenis rousseldenis merged commit 2ed87d1 into OCA:12.0 Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaden tbaden tbaden approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.