Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] rma_sale_mrp: Migration to 13.0 #220

Merged
merged 12 commits into from
May 21, 2021
Merged

[MIG] rma_sale_mrp: Migration to 13.0 #220

merged 12 commits into from
May 21, 2021

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented May 4, 2021 •
edited
Loading

  • Added two little fixes of stuff missing in v13 base modules
  • Tests and methods adapted to v13 kits changes

cc @Tecnativa TT29358

ping @pedrobaeza @victoralmau

@rousseldenis rousseldenis added this to the 13.0 milestone May 4, 2021
@rousseldenis rousseldenis mentioned this pull request May 4, 2021
Closed
7 tasks
chienandalu and others added 11 commits May 5, 2021 09:53
@chienandalu
[FIX] rma: tagged test
b018724
@chienandalu
[FIX] rma_sale: take product from move
213c282
@chienandalu
[FIX] rma_sale: view id
bd0a86b
@chienandalu
[ADD] rma_sale_mrp: New module to refund kits
e5eda43
@pedrocs-exo @chienandalu
Added translation using Weblate (Portuguese)
9e481e4
@pedrocs-exo @chienandalu
Translated using Weblate (Portuguese)
821ed49 
Currently translated at 43.3% (23 of 53 strings)

Translation: rma-12.0/rma-12.0-rma_sale_mrp
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma_sale_mrp/pt/
@marcelsavegnago @chienandalu
Added translation using Weblate (Portuguese (Brazil))
b3fff25
@marcelsavegnago @chienandalu
Translated using Weblate (Portuguese (Brazil))
d108939 
Currently translated at 100.0% (53 of 53 strings)

Translation: rma-12.0/rma-12.0-rma_sale_mrp
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma_sale_mrp/pt_BR/
@chienandalu
[FIX] rma_sale_mrp: infinite loop
fcdc278 
In the wizard, if a component line didn't have any quantity, we could
end in an infinite loop when creating the RMA.
@chienandalu
[FIX] rma_sale_mrp: handle exceptions when qty is forced
8fa7986
@chienandalu
[IMP] rma_sale_mrp: black, isort, prettier
bf521bd
victoralmau
victoralmau approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK.

@chienandalu chienandalu mentioned this pull request May 11, 2021
Merged
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-220-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 679dfc1 into OCA:13.0 May 21, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f9c7656. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
7 participants
@chienandalu @pedrobaeza @OCA-git-bot @victoralmau @rousseldenis @pedrocs-exo @marcelsavegnago