-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
product warranty port v8 #23
Conversation
8bec660
to
27308d8
Compare
Hi, Thanks for the contrib. You don't need to be a member, but you'll need to sign at least the CLA (https://odoo-community.org/page/cla) Can I ask you to fix travis once done ? Then you get my 👍 Regards |
27308d8
to
95f0ef0
Compare
I've fixed what flake issues I could, the last one is more or less unavoidable given how long the field names are. I've already signed the CLA more or less a year ago and checked with cla@odoo-community.org after CLAbot brought it up in #17 to make sure this account is linked in your records. |
./product_warranty/product_warranty.py:79:80: E501 line too long (86 > 79 characters) |
@dreispt: yes, that's what I talk about in my previous comment. |
95f0ef0
to
61c9fd9
Compare
'version': '1.0', | ||
'category': 'Generic Modules/Product', | ||
'description': """ | ||
Product Warranty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move description into a README.rst
file
here is the template to follow:
https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
Is there a way to re-trigger the check after Travis is fixed? |
Yes, hold on, I am restarting them. |
You may need to do a rebase on the 8.0 branch after fetching the new changes |
27f6897
to
c681fc1
Compare
We are green thanks @mistotebe for porting this module 👍 |
I am not a member of the OCA, so I don't believe that I can even propose the license change from GPLv3 to AGPLv3. Other than that, it is a trivial port for a trivial module.