Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product warranty port v8 #23

Merged
merged 4 commits into from
May 22, 2015
Merged

Conversation

mistotebe
Copy link
Contributor

I am not a member of the OCA, so I don't believe that I can even propose the license change from GPLv3 to AGPLv3. Other than that, it is a trivial port for a trivial module.

@jgrandguillaume
Copy link
Member

Hi,

Thanks for the contrib. You don't need to be a member, but you'll need to sign at least the CLA (https://odoo-community.org/page/cla) Can I ask you to fix travis once done ?

Then you get my 👍

Regards

@mistotebe
Copy link
Contributor Author

I've fixed what flake issues I could, the last one is more or less unavoidable given how long the field names are.

I've already signed the CLA more or less a year ago and checked with cla@odoo-community.org after CLAbot brought it up in #17 to make sure this account is linked in your records.

@dreispt
Copy link
Member

dreispt commented May 5, 2015

./product_warranty/product_warranty.py:79:80: E501 line too long (86 > 79 characters)
./product_warranty/product_warranty.py:82:80: E501 line too long (86 > 79 characters)

@mistotebe
Copy link
Contributor Author

@dreispt: yes, that's what I talk about in my previous comment.

'version': '1.0',
'category': 'Generic Modules/Product',
'description': """
Product Warranty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move description into a README.rst file

here is the template to follow:
https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst

@mistotebe
Copy link
Contributor Author

Is there a way to re-trigger the check after Travis is fixed?

@bwrsandman
Copy link

Yes, hold on, I am restarting them.

@bwrsandman
Copy link

You may need to do a rebase on the 8.0 branch after fetching the new changes

@yvaucher
Copy link
Member

We are green thanks @mistotebe for porting this module 👍

yvaucher added a commit that referenced this pull request May 22, 2015
@yvaucher yvaucher merged commit 6085180 into OCA:8.0 May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants