Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] website_rma #244

Merged
merged 21 commits into from
Nov 17, 2021
Merged

[14.0][MIG] website_rma #244

merged 21 commits into from
Nov 17, 2021

Conversation

iwkse
Copy link

@iwkse iwkse commented Nov 10, 2021

No description provided.

@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

Ernesto Tejeda and others added 20 commits November 10, 2021 21:11
This module adds a website form to allows to create an RMA from scratch
Currently translated at 93.8% (15 of 16 strings)

Translation: rma-12.0/rma-12.0-website_rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-website_rma/es/
Currently translated at 43.3% (13 of 30 strings)

Translation: rma-13.0/rma-13.0-website_rma
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-website_rma/ro/
Currently translated at 93.3% (28 of 30 strings)

Translation: rma-13.0/rma-13.0-website_rma
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-website_rma/ro/
Currently translated at 100.0% (30 of 30 strings)

Translation: rma-13.0/rma-13.0-website_rma
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-website_rma/ro/
@iwkse
Copy link
Author

iwkse commented Nov 11, 2021

@pedrobaeza I've applied the changes
regards

@pedrobaeza
Copy link
Member

Great, thanks, now is ready to be reviewed.

@iwkse
Copy link
Author

iwkse commented Nov 11, 2021

@pedrobaeza , @chienandalu
I've pushed again changes, please give me a feedback as it's my first PR on odoo,
regards

@elvise
Copy link

elvise commented Nov 13, 2021

@pedrobaeza @chienandalu any chance for this PR ?

@iwkse
Copy link
Author

iwkse commented Nov 15, 2021

@chienandalu @pedrobaeza PR updated

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iwkse :)

@pedrobaeza
Copy link
Member

/ocabot migration website_rma

/ocabot merge nobump

@iwkse
Copy link
Author

iwkse commented Nov 16, 2021

@chienandalu @pedrobaeza Updated with pre-commit fix

@pedrobaeza
Copy link
Member

/ocabot migration website_rma

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Nov 16, 2021
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 16, 2021
3 tasks
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-244-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 16, 2021
Signed-off-by pedrobaeza
@iwkse
Copy link
Author

iwkse commented Nov 17, 2021

@pedrobaeza is there anything wrong with the bot merging or it's normal it takes time?

@pedrobaeza
Copy link
Member

There should be a problem. Let's try again:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-244-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b8c6d80 into OCA:14.0 Nov 17, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 006a5a4. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

Done, thanks for the contribution. Hope you do much more!

@iwkse
Copy link
Author

iwkse commented Nov 17, 2021

Thank you! Surely, I'll be glad to contribute!
I'm already working on other modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants